From: Dan Rosenberg <drosenberg@vsecurity.com>
To: David Miller <davem@davemloft.net>
Cc: grundler@parisc-linux.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, kyle@mcmartin.ca, jeffm@suse.com,
security@kernel.org
Subject: [PATCH v3] drivers/net/tulip/de4x5.c: fix union member name in DE4X5_GET_REG ioctl
Date: Fri, 17 Sep 2010 01:05:44 -0400 [thread overview]
Message-ID: <1284699944.2565.4.camel@dan> (raw)
In-Reply-To: <20100916.215313.180410528.davem@davemloft.net>
Now with descriptive title, as requested.
This was previously reported as a security issue due to leakage of
uninitialized stack memory. Jeff Mahoney pointed out that this is
incorrect since the copied data is from a union (rather than a struct).
Therefore, this patch is only under consideration for the sake of
correctness, and is not security relevant.
Signed-off-by: Dan Rosenberg <dan.j.rosenberg@gmail.com>
Acked-by: Grant Grundler <grundler@parisc-linux.org>
--- linux-2.6.35.4.orig/drivers/net/tulip/de4x5.c 2010-08-26 19:47:12.000000000 -0400
+++ linux-2.6.35.4/drivers/net/tulip/de4x5.c 2010-09-14 21:26:52.499474207 -0400
@@ -5474,7 +5474,7 @@ de4x5_ioctl(struct net_device *dev, stru
tmp.lval[6] = inl(DE4X5_STRR); j+=4;
tmp.lval[7] = inl(DE4X5_SIGR); j+=4;
ioc->len = j;
- if (copy_to_user(ioc->data, tmp.addr, ioc->len)) return -EFAULT;
+ if (copy_to_user(ioc->data, tmp.lval, ioc->len)) return -EFAULT;
break;
#define DE4X5_DUMP 0x0f /* Dump the DE4X5 Status */
next prev parent reply other threads:[~2010-09-17 5:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 21:43 [PATCH v2] drivers/net/tulip/de4x5.c Dan Rosenberg
2010-09-17 4:53 ` David Miller
2010-09-17 5:05 ` Dan Rosenberg [this message]
2010-09-17 5:27 ` [PATCH v3] drivers/net/tulip/de4x5.c: fix union member name in DE4X5_GET_REG ioctl David Miller
2010-09-17 5:30 ` [PATCH v4] " Dan Rosenberg
2010-09-17 5:34 ` David Miller
2010-09-17 6:36 ` [Security] " Willy Tarreau
2010-09-17 6:37 ` Willy Tarreau
2010-09-17 6:53 ` David Miller
2010-09-17 5:31 ` [PATCH v3] " Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284699944.2565.4.camel@dan \
--to=drosenberg@vsecurity.com \
--cc=davem@davemloft.net \
--cc=grundler@parisc-linux.org \
--cc=jeffm@suse.com \
--cc=kyle@mcmartin.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=security@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).