From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>
Subject: [PATCH net-next-2.6 1/2] net: add IFLA_NUM_TXQ attribute
Date: Fri, 17 Sep 2010 10:31:28 +0200 [thread overview]
Message-ID: <1284712288.3391.36.camel@edumazet-laptop> (raw)
In order to enable multiqueue support on some devices,
add IFLA_NUM_TXQ attribute, number of transmit queues, that "ip link"
can use, at creation and show time :
# ip link add gre34 txqueues 8 type gre remote 192.168.20.80
# ip link sho dev gre34
8: gre34: <POINTOPOINT,NOARP> mtu 1476 qdisc noop state DOWN txqueues 8
link/gre 0.0.0.0 peer 192.168.20.80
Drivers not yet multiqueue aware are supported, because core network
temporary sets real_num_tx_queues to one.
Multiqueue enabled drivers must then sets real_num_tx_queues to
num_tx_queues in their newlink() method.
Limits number of queues to 256 for the moment.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
include/linux/if_link.h | 1 +
net/core/rtnetlink.c | 17 +++++++++++++++++
2 files changed, 18 insertions(+)
diff --git a/include/linux/if_link.h b/include/linux/if_link.h
index 2fc66dd..87dca81 100644
--- a/include/linux/if_link.h
+++ b/include/linux/if_link.h
@@ -116,6 +116,7 @@ enum {
IFLA_STATS64,
IFLA_VF_PORTS,
IFLA_PORT_SELF,
+ IFLA_NUM_TXQ,
__IFLA_MAX
};
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index b2a718d..1b9af34 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -676,6 +676,7 @@ static noinline size_t if_nlmsg_size(const struct net_device *dev)
+ nla_total_size(1) /* IFLA_OPERSTATE */
+ nla_total_size(1) /* IFLA_LINKMODE */
+ nla_total_size(4) /* IFLA_NUM_VF */
+ + nla_total_size(4) /* IFLA_NUM_TXQ */
+ rtnl_vfinfo_size(dev) /* IFLA_VFINFO_LIST */
+ rtnl_port_size(dev) /* IFLA_VF_PORTS + IFLA_PORT_SELF */
+ rtnl_link_get_size(dev); /* IFLA_LINKINFO */
@@ -791,6 +792,9 @@ static int rtnl_fill_ifinfo(struct sk_buff *skb, struct net_device *dev,
if (dev->master)
NLA_PUT_U32(skb, IFLA_MASTER, dev->master->ifindex);
+ if (dev->real_num_tx_queues > 1)
+ NLA_PUT_U32(skb, IFLA_NUM_TXQ, dev->real_num_tx_queues);
+
if (dev->qdisc)
NLA_PUT_STRING(skb, IFLA_QDISC, dev->qdisc->ops->id);
@@ -922,6 +926,7 @@ const struct nla_policy ifla_policy[IFLA_MAX+1] = {
[IFLA_MTU] = { .type = NLA_U32 },
[IFLA_LINK] = { .type = NLA_U32 },
[IFLA_TXQLEN] = { .type = NLA_U32 },
+ [IFLA_NUM_TXQ] = { .type = NLA_U32 },
[IFLA_WEIGHT] = { .type = NLA_U32 },
[IFLA_OPERSTATE] = { .type = NLA_U8 },
[IFLA_LINKMODE] = { .type = NLA_U8 },
@@ -1357,6 +1362,18 @@ struct net_device *rtnl_create_link(struct net *src_net, struct net *net,
if (err)
goto err;
}
+ if (tb[IFLA_NUM_TXQ]) {
+ err = -EINVAL;
+ num_queues = nla_get_u32(tb[IFLA_NUM_TXQ]);
+ if (num_queues < 1 || num_queues > 256)
+ goto err;
+ /* multiqueue drivers have to set
+ * dev->real_num_tx_queues = dev->num_tx_queues;
+ * in their ->newlink() method. We force a temporary
+ * single queue to be compatable with old drivers.
+ */
+ real_num_queues = 1;
+ }
err = -ENOMEM;
dev = alloc_netdev_mq(ops->priv_size, ifname, ops->setup, num_queues);
if (!dev)
next reply other threads:[~2010-09-17 8:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-17 8:31 Eric Dumazet [this message]
2010-09-17 23:29 ` [PATCH net-next-2.6 1/2] net: add IFLA_NUM_TXQ attribute David Miller
2010-09-18 5:33 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284712288.3391.36.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox