Re: [E1000-devel] [PATCH] net: enable GRO by default for vlan devices

David Miller
2010-09-16T05:51:28Z

From: Stephen Hemminger <shemminger@vyatta.com>
Date: Wed, 15 Sep 2010 18:16:16 -0700

> On Thu, 16 Sep 2010 00:28:11 +0200
> Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
>> BTW, we have a similar problem for bonding ( GRO is disabled )
>>
>> # ethtool -K bond0 gro off
>> # ethtool -K bond0 gro on
>> Cannot set device GRO settings: Invalid argument
>>
>> Same for vlans on top of bond0
>
> Bridge has same problem as well.

Looking this over it should be a simple matter of:

1) Adding the generic get/set gro ethtool ops to bonding
and bridge device ops.

2) Set NETIF_F_GRO in bond/bridge device flags

3) Maybe some minor fiddling with netdev_increment_features
and the flag macros it uses?

Patches welcome :-)