Re: [PATCH] ixgbe: add GRO to vlan_features

David Miller
2010-09-15T04:35:44Z

From: Brandon Philips <bphilips@suse.de>
Date: Tue, 14 Sep 2010 18:50:53 -0700

> When running a vlan -> bridge -> domU setup I was noticing poor RX
> performance. It seems ixgbe and other drivers don't have NETIF_F_GRO set
> in vlan_features and thus GRO is off by default for vlans.
>
> I see no reason why the other drivers shouldn't be fixed. If this is OK
> I will go off and fix the rest.
>
> Signed-off-by: Brandon Philips <bphilips@suse.de>

I think it should be set, but why don't we do this another way?

This feature is a software feature, essentially, so if it is published
in netdev->features we can simply propagate it automatically to
netdev->vlan_features at device registry time in the core networking.

------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel&#174; Ethernet, visit http://communities.intel.com/community/wired