From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [PATCH net-next-2.6 0/8] sfc and ethtool changes for 2.6.37 Date: Wed, 22 Sep 2010 16:27:03 +0100 Message-ID: <1285169223.2279.1.camel@achroite.uk.solarflarecom.com> References: <1285008056.2282.103.camel@achroite.uk.solarflarecom.com> <20100921.145827.112592957.davem@davemloft.net> <20100921.162326.226765001.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-net-drivers@solarflare.com To: David Miller Return-path: Received: from mail.solarflare.com ([216.237.3.220]:55700 "EHLO exchange.solarflare.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754678Ab0IVP1H (ORCPT ); Wed, 22 Sep 2010 11:27:07 -0400 In-Reply-To: <20100921.162326.226765001.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 2010-09-21 at 16:23 -0700, David Miller wrote: > From: David Miller > Date: Tue, 21 Sep 2010 14:58:27 -0700 (PDT) > > > From: Ben Hutchings > > Date: Mon, 20 Sep 2010 19:40:56 +0100 > > > >> This series adds Ethernet-level filtering and explicit filter clearing > >> to the ethtool RX n-tuple interface, and implements it in the sfc > >> driver. > >> > >> There is a cleanup patch on the end which is preparation for the > >> following RFC patch series but is worthwhile anyway. > >> > >> Ben Hutchings (8): > >> ethtool: Define RX n-tuple action to clear a rule > >> ethtool: Add Ethernet MAC-level filtering/steering > >> ethtool: Allocate register dump buffer with vmalloc() > >> sfc: Add filter table management > >> sfc: Implement the ethtool RX n-tuple control functions > >> sfc: Include RX IP filter table in register dump > >> sfc: Set net_device::num_rx_queues once we know the correct value > >> sfc: Clean up and correct comments on efx_monitor() > > > > All applied except patch #7 as noted in the thread for that patch. > > Ben, just FYI, I had to add "linux/vmalloc.h" includes to both > net/core/ethtool.c and drivers/net/sfc/net_driver.h otherwise > the build breaks on some architectures. > > x86 can be a really bad arch to validates builds on because it > currently gets vmalloc.h implicitly by some of it's core header files. > > In particular, asm/io.h :-/ Thanks, and sorry for missing this. We have some SPARC systems that I could potentially test on but I think they're limited to running Solaris. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.