From: Eric Dumazet <eric.dumazet@gmail.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-net-drivers@solarflare.com
Subject: Re: [PATCH net-next-2.6 7/8] sfc: Set net_device::num_rx_queues once we know the correct value
Date: Wed, 22 Sep 2010 17:44:46 +0200 [thread overview]
Message-ID: <1285170286.2639.428.camel@edumazet-laptop> (raw)
In-Reply-To: <1285169327.2279.3.camel@achroite.uk.solarflarecom.com>
Le mercredi 22 septembre 2010 à 16:28 +0100, Ben Hutchings a écrit :
>
> That still doesn't solve the original problem, since drivers generally
> won't know how many RX queues they should (or can) create until some
> time after calling alloc_netdev_mq().
>
> You know very well why we distinguish real_num_tx_queues and
> num_tx_queues; what's so different about RX queues?
rx queues were added by Tom for RPS.
No function prototypes were changed to provide it as a new parameter.
What we need is to extend alloc_netdev_mq() to take a new rx_queue_count
parameter.
Then allow these txq/rxq parameters to be "unset for the moment", and
provide a new function to allocate / populate queues when driver knows
what to do, _after_ its alloc_netdev_mq() call.
Your one line patch is a work around, not a clean solution.
next prev parent reply other threads:[~2010-09-22 15:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-20 18:40 [PATCH net-next-2.6 0/8] sfc and ethtool changes for 2.6.37 Ben Hutchings
2010-09-20 18:41 ` [PATCH net-next-2.6 1/8] ethtool: Define RX n-tuple action to clear a rule Ben Hutchings
2010-09-20 18:42 ` [PATCH net-next-2.6 2/8] ethtool: Add Ethernet MAC-level filtering/steering Ben Hutchings
2010-09-20 18:42 ` [PATCH net-next-2.6 3/8] ethtool: Allocate register dump buffer with vmalloc() Ben Hutchings
2010-09-20 18:43 ` [PATCH net-next-2.6 4/8] sfc: Add filter table management Ben Hutchings
2010-09-20 18:43 ` [PATCH net-next-2.6 5/8] sfc: Implement the ethtool RX n-tuple control functions Ben Hutchings
2010-09-20 18:43 ` [PATCH net-next-2.6 6/8] sfc: Include RX IP filter table in register dump Ben Hutchings
2010-09-20 18:43 ` [PATCH net-next-2.6 7/8] sfc: Set net_device::num_rx_queues once we know the correct value Ben Hutchings
2010-09-20 18:54 ` Eric Dumazet
2010-09-20 19:05 ` Ben Hutchings
2010-09-21 21:57 ` David Miller
2010-09-22 1:31 ` Ben Hutchings
2010-09-22 1:38 ` David Miller
2010-09-22 15:28 ` Ben Hutchings
2010-09-22 15:44 ` Eric Dumazet [this message]
2010-09-20 18:44 ` [PATCH net-next-2.6 8/8] sfc: Clean up and correct comments on efx_monitor() Ben Hutchings
2010-09-21 21:58 ` [PATCH net-next-2.6 0/8] sfc and ethtool changes for 2.6.37 David Miller
2010-09-21 23:23 ` David Miller
2010-09-22 15:27 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285170286.2639.428.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox