From: Ben Hutchings <ben@decadent.org.uk>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
romieu@fr.zoreil.com, sgruszka@redhat.com,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/2 -next] r8169: allocate with GFP_KERNEL flag when able to sleep
Date: Sun, 26 Sep 2010 13:46:19 +0100 [thread overview]
Message-ID: <1285505179.2697.210.camel@localhost> (raw)
In-Reply-To: <1285481398.2436.7.camel@edumazet-laptop>
[-- Attachment #1: Type: text/plain, Size: 920 bytes --]
On Sun, 2010-09-26 at 08:09 +0200, Eric Dumazet wrote:
> Le dimanche 26 septembre 2010 à 00:33 +0100, Ben Hutchings a écrit :
> > On Sat, 2010-09-25 at 11:12 +0200, Eric Dumazet wrote:
> > [...]
> > > The r8169 current problem is its currently copying all incoming frames.
> > > I guess nobody cares or noticed the performance drop.
> > > (But commit c0cd884a is recent (2.6.34), this is not yet in
> > > production...)
> >
> > Since that was a security fix it was backported to 2.6.32.12 and
> > probably most distribution kernels. So yes it is in production.
>
> Maybe in your company, not a single machine in mine ;)
>
> Most linux servers in production run much older kernels.
>
> rhel 5 -> 2.6.18
> debian 5 -> 2.6.26.x
Those both have the fix. Look for CVE-2009-4537 in the changelog.
Ben.
--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2010-09-26 12:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 12:01 [PATCH 1/2 -next] r8169: allocate with GFP_KERNEL flag when able to sleep Stanislaw Gruszka
2010-09-23 12:01 ` [PATCH 2/2 -next] r8169: use device model DMA API Stanislaw Gruszka
2010-09-23 14:59 ` Denis Kirjanov
2010-09-23 15:23 ` Stanislaw Gruszka
2010-09-23 21:20 ` [PATCH 1/2 -next] r8169: allocate with GFP_KERNEL flag when able to sleep Francois Romieu
2010-09-24 11:18 ` Stanislaw Gruszka
2010-09-24 22:24 ` Francois Romieu
2010-09-25 5:37 ` David Miller
2010-09-25 6:06 ` Eric Dumazet
2010-09-25 7:13 ` David Miller
2010-09-25 9:12 ` Eric Dumazet
2010-09-25 23:33 ` Ben Hutchings
2010-09-26 6:09 ` Eric Dumazet
2010-09-26 12:46 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285505179.2697.210.camel@localhost \
--to=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).