From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: linux-kernel@vger.kernel.org
Cc: "Trond Myklebust" <Trond.Myklebust@netapp.com>,
"J. Bruce Fields" <bfields@fieldses.org>,
"Neil Brown" <neilb@suse.de>,
"David S. Miller" <davem@davemloft.net>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Randy Dunlap" <randy.dunlap@oracle.com>,
linux-nfs@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH] sunrpc: prompt for RPCSEC_GSS_KRB5 even if NFS_V4 is enabled
Date: Mon, 27 Sep 2010 12:41:59 +0200 [thread overview]
Message-ID: <1285584120-16860-1-git-send-email-u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <20100909181454.GB14915@pengutronix.de>
NFS_V4 works fine without RPCSEC_GSS_KRB5 (even without CRYPTO).
This dependency was introduced in
df486a2 (NFS: Fix the selection of security flavours in Kconfig)
to fix a build failure as RPCSEC_GSS_KRB5 was thought to be needed for
NFS_V4. The fix didn't work completely as NFS_V4 didn't enforce CRYPTO
and so the select on RPCSEC_GSS_KRB5 didn't work in all situations (e.g.
arm/mx1_defconfig).
This was rectified by
827e345 (SUNRPC: Fix the NFSv4 and RPCSEC_GSS Kconfig dependencies)
but the magic for RPCSEC_GSS_KRB5 introduced by df486a2 wasn't reverted.
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Hello,
after Trond sent me the patch that later ended in 827e345702 I suggested
to fold the patch below into it[1], but without reaction and success as I
noticed just now. :-(
Best regards
Uwe
[1] http://thread.gmane.org/gmane.linux.kernel/1027380/focus=1033847
net/sunrpc/Kconfig | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/net/sunrpc/Kconfig b/net/sunrpc/Kconfig
index 3376d76..442efe1 100644
--- a/net/sunrpc/Kconfig
+++ b/net/sunrpc/Kconfig
@@ -20,8 +20,7 @@ config SUNRPC_XPRT_RDMA
config RPCSEC_GSS_KRB5
tristate
depends on SUNRPC && CRYPTO
- prompt "Secure RPC: Kerberos V mechanism" if !(NFS_V4 || NFSD_V4)
- default y
+ prompt "Secure RPC: Kerberos V mechanism"
select SUNRPC_GSS
select CRYPTO_MD5
select CRYPTO_DES
--
1.7.2.3
next parent reply other threads:[~2010-09-27 10:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100909181454.GB14915@pengutronix.de>
2010-09-27 10:41 ` Uwe Kleine-König [this message]
[not found] ` <1285584120-16860-1-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-09-27 11:39 ` [PATCH] sunrpc: prompt for RPCSEC_GSS_KRB5 even if NFS_V4 is enabled Trond Myklebust
2010-09-27 12:54 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285584120-16860-1-git-send-email-u.kleine-koenig@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=Trond.Myklebust@netapp.com \
--cc=bfields@fieldses.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).