From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [PATCH v11 03/17] Add a ndo_mp_port_prep pointer to net_device_ops. Date: Mon, 27 Sep 2010 14:42:33 +0100 Message-ID: <1285594953.2263.5.camel@achroite.uk.solarflarecom.com> References: <1285388855-27410-1-git-send-email-xiaohui.xin@intel.com> <79267b300503d98d43ccfcf11d1374f59fec8578.1285385607.git.xiaohui.xin@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, mingo@elte.hu, davem@davemloft.net, herbert@gondor.hengli.com.au, jdike@linux.intel.com To: xiaohui.xin@intel.com Return-path: Received: from mail.solarflare.com ([216.237.3.220]:27485 "EHLO exchange.solarflare.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759341Ab0I0Nmh (ORCPT ); Mon, 27 Sep 2010 09:42:37 -0400 In-Reply-To: <79267b300503d98d43ccfcf11d1374f59fec8578.1285385607.git.xiaohui.xin@intel.com> Sender: netdev-owner@vger.kernel.org List-ID: On Sat, 2010-09-25 at 12:27 +0800, xiaohui.xin@intel.com wrote: > From: Xin Xiaohui > > If the driver want to allocate external buffers, > then it can export it's capability, as the skb > buffer header length, the page length can be DMA, etc. > The external buffers owner may utilize this. [...] This information needs to be included in the comment above struct net_device_ops, not just in the commit message. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.