Re: [PATCH net-next 2.6] myri10ge: DCA update

[Eric Dumazet <eric.dumazet@gmail.com>]

Le mardi 28 septembre 2010 à 09:41 -0400, Andrew Gallatin a écrit :
> This patch contains the following DCA improvements to myri10ge:
> 
> 1) Finally move myri10ge to use dca3 API
> 
> 2) Disable PCIe relaxed ordering when enabling DCA on
>      myri10ge.  This provides a performance boost on Nehalem
>      based Xeons
> 
> 3) Make sure to properly initialize NIC's DCA state when it is enabled,
>      rather than giving the NIC a bogus tag (0) and waiting for
>      the first received packet to trigger an update.  Not using a
>      real tag can cause hardware exceptions on some motherboards
>      when a CPU socket is empty.
> 
> 3) Always update the cached CPU when our interrupt affinity changes
>      so as to avoid excessive calls to dca3_get_tag()
> 
> Signed-off-by: Andrew Gallatin <gallatin@myri.com>
> Signed-off-by: Loic Prylli <loic@myri.com>

ERROR: return is not a function, parentheses are not required
#99: FILE: drivers/net/myri10ge/myri10ge.c:1086:
+		return (0);

ERROR: trailing whitespace
#108: FILE: drivers/net/myri10ge/myri10ge.c:1095:
+^Ireturn (ret);^I$

ERROR: return is not a function, parentheses are not required
#108: FILE: drivers/net/myri10ge/myri10ge.c:1095:
+	return (ret);	

total: 3 errors, 0 warnings, 71 lines checked