From: Eric Dumazet <eric.dumazet@gmail.com>
To: nicolas.dichtel@6wind.com
Cc: David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next-2.6] ip_gre: lockless xmit
Date: Wed, 29 Sep 2010 10:18:08 +0200 [thread overview]
Message-ID: <1285748288.2615.15.camel@edumazet-laptop> (raw)
In-Reply-To: <4CA2F46B.1070607@6wind.com>
Le mercredi 29 septembre 2010 à 10:10 +0200, Nicolas Dichtel a écrit :
> NETIF_F_LLTX is marked as deprecated:
>
> include/linux/netdevice.h:
> #define NETIF_F_LLTX 4096 /* LockLess TX - deprecated.
> Please */
> /* do not use LLTX in new
> drivers */
>
> Is it right to use it?
>
In this particular case (and drivers/net/loopback.c), yes.
This is the only way to avoid the locking in core network
(net/core/dev.c)
What is deprecated is to assert NETIF_F_LLTX and yet, use a lock in the
ndo_xmit() driver method.
next prev parent reply other threads:[~2010-09-29 8:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 9:05 [PATCH net-next-2.6] ip_gre: lockless xmit Eric Dumazet
2010-09-29 8:10 ` Nicolas Dichtel
2010-09-29 8:18 ` Eric Dumazet [this message]
2010-09-29 8:21 ` David Miller
2010-09-29 17:33 ` Jesse Gross
2010-09-29 18:43 ` Eric Dumazet
2010-09-29 19:04 ` [PATCH net-next-2.6] net: add a recursion limit in xmit path Eric Dumazet
2010-09-29 20:23 ` David Miller
2010-09-29 19:24 ` [PATCH net-next-2.6] ip_gre: lockless xmit Jesse Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285748288.2615.15.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox