From: Johannes Berg <johannes@sipsolutions.net>
To: Julian Calaby <julian.calaby@gmail.com>
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org, tgraf@suug.ch
Subject: Re: [RFC 1/2] genetlink: introduce pre_doit/post_doit hooks
Date: Fri, 01 Oct 2010 00:47:01 +0200 [thread overview]
Message-ID: <1285886821.5137.29.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1285886690.5137.28.camel@jlt3.sipsolutions.net>
On Fri, 2010-10-01 at 00:44 +0200, Johannes Berg wrote:
> On Fri, 2010-10-01 at 08:41 +1000, Julian Calaby wrote:
>
> > > d) include two private pointers in each info
> > > struct passed between all these operations
> > > including doit(). (It's two because I'll
> > > need two in nl80211 -- can be extended.)
> >
> > Stupid question:
> >
> > Why not have a priv struct rather than an arbitrary array of two pointers?
>
> It'd have to be dynamically allocated, and the "arbitrary" array of two
> pointers can be on the stack.
Maybe I should elaborate -- a priv struct basically means just a single
pointer, and then I'd have to allocate something to hold two pointers in
nl80211 and assign it to that single pointer.
johannes
next prev parent reply other threads:[~2010-09-30 22:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 21:10 [RFC 0/2] generic netlink doit generalisation Johannes Berg
2010-09-30 21:10 ` [RFC 1/2] genetlink: introduce pre_doit/post_doit hooks Johannes Berg
[not found] ` <20100930211131.021309930-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2010-09-30 22:41 ` Julian Calaby
2010-09-30 22:44 ` Johannes Berg
2010-09-30 22:47 ` Johannes Berg [this message]
2010-09-30 22:49 ` Johannes Berg
2010-09-30 22:51 ` Julian Calaby
[not found] ` <AANLkTimVMGHNkK=o650qzZfvUp3mWRAG_=60etVbEBxh-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-09-30 22:55 ` Johannes Berg
[not found] ` <1285887352.5137.34.camel-8upI4CBIZJIJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2010-09-30 23:14 ` Julian Calaby
2010-09-30 21:10 ` [RFC 2/2] nl80211: use the new genetlink pre/post_doit hooks Johannes Berg
[not found] ` <20100930211013.472957770-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2010-09-30 22:39 ` [RFC 0/2] generic netlink doit generalisation Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285886821.5137.29.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=julian.calaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).