From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: IPv4: sysctl table check failed [was: mmotm 2010-10-07-14-08 uploaded] Date: Fri, 08 Oct 2010 00:22:15 +0200 Message-ID: <1286490135.6536.75.camel@edumazet-laptop> References: <201010072140.o97Le69i025659@imap1.linux-foundation.org> <4CAE4479.6010606@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, mm-commits@vger.kernel.org, ML netdev , "David S. Miller" To: Jiri Slaby Return-path: Received: from mail-wy0-f174.google.com ([74.125.82.174]:41111 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750978Ab0JGWWU (ORCPT ); Thu, 7 Oct 2010 18:22:20 -0400 In-Reply-To: <4CAE4479.6010606@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: Le vendredi 08 octobre 2010 =C3=A0 00:06 +0200, Jiri Slaby a =C3=A9crit= : > On 10/07/2010 11:08 PM, akpm@linux-foundation.org wrote: > > The mm-of-the-moment snapshot 2010-10-07-14-08 has been uploaded to >=20 > Hi, I got bunch of "sysctl table check failed" below. All seem to be > related to ipv4: I would say, sysctl check is buggy :( min/max are optional [PATCH] sysctl: min/max bounds are optional sysctl check complains when proc_doulongvec_minmax or proc_doulongvec_ms_jiffies_minmax are used by a vector of longs (with more than one element), with no min or max value specified. This is unexpected, given we had a bug on this min/max handling :) Reported-by: Jiri Slaby Signed-off-by: Eric Dumazet --- kernel/sysctl_check.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/kernel/sysctl_check.c b/kernel/sysctl_check.c index 04cdcf7..10b90d8 100644 --- a/kernel/sysctl_check.c +++ b/kernel/sysctl_check.c @@ -143,15 +143,6 @@ int sysctl_check_table(struct nsproxy *namespaces,= struct ctl_table *table) if (!table->maxlen) set_fail(&fail, table, "No maxlen"); } - if ((table->proc_handler =3D=3D proc_doulongvec_minmax) || - (table->proc_handler =3D=3D proc_doulongvec_ms_jiffies_minmax))= { - if (table->maxlen > sizeof (unsigned long)) { - if (!table->extra1) - set_fail(&fail, table, "No min"); - if (!table->extra2) - set_fail(&fail, table, "No max"); - } - } #ifdef CONFIG_PROC_SYSCTL if (table->procname && !table->proc_handler) set_fail(&fail, table, "No proc_handler");