From: "Rémi Denis-Courmont" <remi@remlab.net>
To: netdev@vger.kernel.org
Cc: "Rémi Denis-Courmont" <remi.denis-courmont@nokia.com>
Subject: [PATCH 2/4] Phonet: advise against enabling the pipe controller
Date: Fri, 8 Oct 2010 17:02:01 +0300 [thread overview]
Message-ID: <1286546523-3340-2-git-send-email-remi@remlab.net> (raw)
In-Reply-To: <1286546523-3340-1-git-send-email-remi@remlab.net>
From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
As it currently is, the new code path is not compatible with existing
Nokia modems. This would break existing userspace for Nokia modem, such
as the existing oFono ISI driver.
Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
---
net/phonet/Kconfig | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/net/phonet/Kconfig b/net/phonet/Kconfig
index 901956a..a4fceb8 100644
--- a/net/phonet/Kconfig
+++ b/net/phonet/Kconfig
@@ -24,4 +24,5 @@ config PHONET_PIPECTRLR
data with Nokia Slim modems like WG2.5 used on ST-Ericsson U8500
platform.
- If unsure, say N.
+ This option is incompatible with older Nokia modems.
+ Say N here unless you really know what you are doing.
--
1.7.0.4
next prev parent reply other threads:[~2010-10-08 14:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-08 14:02 [PATCH 1/4] Phonet: add to MAINTAINERS and add myself Rémi Denis-Courmont
2010-10-08 14:02 ` Rémi Denis-Courmont [this message]
2010-10-08 14:02 ` [PATCH 3/4] Phonet: cleanup pipe enable socket option Rémi Denis-Courmont
2010-10-08 14:02 ` [PATCH 4/4] Phonet: mark the pipe controller as EXPERIMENTAL Rémi Denis-Courmont
2010-10-08 21:17 ` David Miller
2010-10-11 7:09 ` Kumar SANGHVI
2010-10-11 8:24 ` Rémi Denis-Courmont
2010-10-08 21:17 ` [PATCH 3/4] Phonet: cleanup pipe enable socket option David Miller
2010-10-11 6:50 ` Kumar SANGHVI
2010-10-08 21:17 ` [PATCH 2/4] Phonet: advise against enabling the pipe controller David Miller
2010-10-09 10:20 ` Rémi Denis-Courmont
2010-10-11 6:49 ` Kumar SANGHVI
2010-10-08 21:17 ` [PATCH 1/4] Phonet: add to MAINTAINERS and add myself David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286546523-3340-2-git-send-email-remi@remlab.net \
--to=remi@remlab.net \
--cc=netdev@vger.kernel.org \
--cc=remi.denis-courmont@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).