From: "Rémi Denis-Courmont" <remi@remlab.net>
To: netdev@vger.kernel.org
Cc: "Rémi Denis-Courmont" <remi.denis-courmont@nokia.com>
Subject: [PATCH 4/4] Phonet: mark the pipe controller as EXPERIMENTAL
Date: Fri, 8 Oct 2010 17:02:03 +0300 [thread overview]
Message-ID: <1286546523-3340-4-git-send-email-remi@remlab.net> (raw)
In-Reply-To: <1286546523-3340-3-git-send-email-remi@remlab.net>
From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
There are a bunch of issues that need to be fixed, including:
- GFP_KERNEL allocations from atomic context
(and GFP_ATOMIC in process context),
- abuse of the setsockopt() call convention,
- unprotected/unlocked static variables...
IMHO, we will need to alter the userspace ABI when we fix it. So mark
the configuration option as EXPERIMENTAL for the time being (or should
it be BROKEN instead?).
Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
---
net/phonet/Kconfig | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/phonet/Kconfig b/net/phonet/Kconfig
index a4fceb8..0d9b8a2 100644
--- a/net/phonet/Kconfig
+++ b/net/phonet/Kconfig
@@ -16,8 +16,8 @@ config PHONET
will be called phonet. If unsure, say N.
config PHONET_PIPECTRLR
- bool "Phonet Pipe Controller"
- depends on PHONET
+ bool "Phonet Pipe Controller (EXPERIMENTAL)"
+ depends on PHONET && EXPERIMENTAL
default N
help
The Pipe Controller implementation in Phonet stack to support Pipe
--
1.7.0.4
next prev parent reply other threads:[~2010-10-08 14:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-08 14:02 [PATCH 1/4] Phonet: add to MAINTAINERS and add myself Rémi Denis-Courmont
2010-10-08 14:02 ` [PATCH 2/4] Phonet: advise against enabling the pipe controller Rémi Denis-Courmont
2010-10-08 14:02 ` [PATCH 3/4] Phonet: cleanup pipe enable socket option Rémi Denis-Courmont
2010-10-08 14:02 ` Rémi Denis-Courmont [this message]
2010-10-08 21:17 ` [PATCH 4/4] Phonet: mark the pipe controller as EXPERIMENTAL David Miller
2010-10-11 7:09 ` Kumar SANGHVI
2010-10-11 8:24 ` Rémi Denis-Courmont
2010-10-08 21:17 ` [PATCH 3/4] Phonet: cleanup pipe enable socket option David Miller
2010-10-11 6:50 ` Kumar SANGHVI
2010-10-08 21:17 ` [PATCH 2/4] Phonet: advise against enabling the pipe controller David Miller
2010-10-09 10:20 ` Rémi Denis-Courmont
2010-10-11 6:49 ` Kumar SANGHVI
2010-10-08 21:17 ` [PATCH 1/4] Phonet: add to MAINTAINERS and add myself David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286546523-3340-4-git-send-email-remi@remlab.net \
--to=remi@remlab.net \
--cc=netdev@vger.kernel.org \
--cc=remi.denis-courmont@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).