From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: xiaohui.xin@intel.com, netdev@vger.kernel.org,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
mst@redhat.com, mingo@elte.hu, herbert@gondor.apana.org.au,
jdike@linux.intel.com
Subject: Re: [PATCH v12 06/17] Use callback to deal with skb_release_data() specially.
Date: Mon, 11 Oct 2010 17:42:11 +0200 [thread overview]
Message-ID: <1286811731.2737.28.camel@edumazet-laptop> (raw)
In-Reply-To: <20101011.082728.193709462.davem@davemloft.net>
Le lundi 11 octobre 2010 à 08:27 -0700, David Miller a écrit :
> From: "Xin, Xiaohui" <xiaohui.xin@intel.com>
> Date: Mon, 11 Oct 2010 15:06:05 +0800
>
> > That's to avoid the new cache miss caused by using destructor_arg in data path
> > like skb_release_data().
> > That's based on the comment from Eric Dumazet on v7 patches.
>
> Thanks for the explanation.
Anyway, frags[] must be the last field of "struct skb_shared_info"
since commit fed66381 (net: pskb_expand_head() optimization)
It seems Xin worked on a quite old tree.
next prev parent reply other threads:[~2010-10-11 15:42 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 14:04 [PATCH v12 00/17] Provide a zero-copy method on KVM virtio-net xiaohui.xin
2010-09-30 14:04 ` [PATCH v12 01/17] Add a new structure for skb buffer from external xiaohui.xin
2010-09-30 14:04 ` [PATCH v12 02/17] Add a new struct for device to manipulate external buffer xiaohui.xin
2010-09-30 14:04 ` [PATCH v12 03/17] Add a ndo_mp_port_prep pointer to net_device_ops xiaohui.xin
2010-09-30 14:04 ` [PATCH v12 04/17] Add a function make external buffer owner to query capability xiaohui.xin
2010-09-30 14:04 ` [PATCH v12 05/17] Add a function to indicate if device use external buffer xiaohui.xin
2010-09-30 14:04 ` [PATCH v12 06/17] Use callback to deal with skb_release_data() specially xiaohui.xin
2010-10-01 7:14 ` David Miller
2010-10-11 7:06 ` Xin, Xiaohui
2010-10-11 15:27 ` David Miller
2010-10-11 15:42 ` Eric Dumazet [this message]
2010-10-12 1:24 ` Xin, Xiaohui
2010-09-30 14:04 ` [PATCH v12 07/17]Modify netdev_alloc_page() to get external buffer xiaohui.xin
2010-09-30 14:04 ` [PATCH v12 08/17] Modify netdev_free_page() to release " xiaohui.xin
2010-09-30 14:04 ` [PATCH v12 09/17] Don't do skb recycle, if device use " xiaohui.xin
2010-09-30 14:04 ` [PATCH v12 10/17] Add a hook to intercept external buffers from NIC driver xiaohui.xin
2010-09-30 14:22 ` Eric Dumazet
2010-10-11 7:06 ` Xin, Xiaohui
2010-09-30 14:04 ` [PATCH v12 11/17] Add header file for mp device xiaohui.xin
2010-09-30 14:04 ` [PATCH v12 13/17] Add a kconfig entry and make entry " xiaohui.xin
2010-09-30 14:04 ` [PATCH v12 12/17] Add mp(mediate passthru) device xiaohui.xin
2010-10-03 13:12 ` Michael S. Tsirkin
2010-10-18 8:30 ` Xin, Xiaohui
2010-09-30 14:04 ` [PATCH v12 14/17] Provides multiple submits and asynchronous notifications xiaohui.xin
2010-09-30 14:04 ` [PATCH v12 15/17]An example how to modifiy NIC driver to use napi_gro_frags() interface xiaohui.xin
2010-09-30 14:04 ` [PATCH v12 16/17]An example how to alloc user buffer based on " xiaohui.xin
2010-09-30 14:04 ` [PATCH v12 17/17]add two new ioctls for mp device xiaohui.xin
2010-10-01 0:00 ` [PATCH v12 00/17] Provide a zero-copy method on KVM virtio-net Xin, Xiaohui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286811731.2737.28.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jdike@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=xiaohui.xin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox