Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: avagin@gmail.com
Cc: David Miller <davem@davemloft.net>,
	mjt@tls.msk.ru, avagin@openvz.org, stable@kernel.org,
	netdev@vger.kernel.org, krkumar2@in.ibm.com
Subject: Re: [STABLE 2.6.32 PATCH] net: release dst entry while cache-hot for GSO case too
Date: Mon, 11 Oct 2010 18:30:52 +0200	[thread overview]
Message-ID: <1286814652.2737.41.camel@edumazet-laptop> (raw)
In-Reply-To: <4CB33907.5060803@gmail.com>

Le lundi 11 octobre 2010 à 20:19 +0400, Andrew Vagin a écrit :
> On 10/11/2010 07:59 PM, David Miller wrote:
> > From: Eric Dumazet<eric.dumazet@gmail.com>
> > Date: Mon, 11 Oct 2010 17:46:49 +0200
> >
> >> This patch was an optimization, not a bug fix.
> > Right, this has no business going into 2.6.32-stable at all.
> This is bug fix. Now nobody drops dst in case gso and veth, because the 
> commit 60df914e295a21a223e43a7ee01e0c73c64dd111 deletes skb_dst_drop 
> from the veth.c. We should commit my patch or revert commit 60df914e.
> 
> We have two bug reports:
> 
> http://www.spinics.net/lists/netdev/msg142104.html
> 
> http://bugzilla.openvz.org/show_bug.cgi?id=1634
> 
> Taylan verified that the patch really fix his bug.

Now that makes sense ;)

This is always good to mention commit id of a bug origin.

Because reading your patch (changelog and content), it was not obvious
it fixed a bug.

Thanks !



  reply	other threads:[~2010-10-11 16:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-11 15:20 [STABLE 2.6.32 PATCH] net: release dst entry while cache-hot for GSO case too Andrey Vagin
2010-10-11 15:40 ` Michael Tokarev
2010-10-11 15:46   ` Eric Dumazet
2010-10-11 15:59     ` David Miller
2010-10-11 16:19       ` Andrew Vagin
2010-10-11 16:30         ` Eric Dumazet [this message]
2010-10-11 16:55           ` Michael Tokarev
2010-10-26 18:54           ` David Miller
2010-12-08 22:47             ` avagin
2010-12-08 23:05               ` Greg KH
2010-12-09  6:43                 ` [stable] " avagin
2010-12-09 18:19                   ` Greg KH
2010-12-21  0:07                     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1286814652.2737.41.camel@edumazet-laptop \
    --to=eric.dumazet@gmail.com \
    --cc=avagin@gmail.com \
    --cc=avagin@openvz.org \
    --cc=davem@davemloft.net \
    --cc=krkumar2@in.ibm.com \
    --cc=mjt@tls.msk.ru \
    --cc=netdev@vger.kernel.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox