* [PATCH net-next] bnx2x: Fixing a typo: added a missing RSS enablement
@ 2010-10-12 19:02 Dmitry Kravkov
2010-10-12 19:18 ` Eric Dumazet
2010-10-12 19:26 ` Joe Perches
0 siblings, 2 replies; 6+ messages in thread
From: Dmitry Kravkov @ 2010-10-12 19:02 UTC (permalink / raw)
To: davem, netdev, eric.dumazet; +Cc: vladz, eilong
Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Dmitry Kravkov <dmitry@broadcom.com>
Signed-off-by: Vladislav Zolotarov <vladz@broadcom.com>
---
drivers/net/bnx2x/bnx2x_main.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/bnx2x/bnx2x_main.c b/drivers/net/bnx2x/bnx2x_main.c
index 7a9556b..ead524b 100644
--- a/drivers/net/bnx2x/bnx2x_main.c
+++ b/drivers/net/bnx2x/bnx2x_main.c
@@ -2486,6 +2486,7 @@ void bnx2x_pf_init(struct bnx2x *bp)
* if (is_eth_multi(bp))
* flags |= FUNC_FLG_RSS;
*/
+ flags |= FUNC_FLG_RSS;
/* function setup */
if (flags & FUNC_FLG_RSS) {
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH net-next] bnx2x: Fixing a typo: added a missing RSS enablement
2010-10-12 19:02 [PATCH net-next] bnx2x: Fixing a typo: added a missing RSS enablement Dmitry Kravkov
@ 2010-10-12 19:18 ` Eric Dumazet
2010-10-12 19:31 ` David Miller
2010-10-12 19:26 ` Joe Perches
1 sibling, 1 reply; 6+ messages in thread
From: Eric Dumazet @ 2010-10-12 19:18 UTC (permalink / raw)
To: Dmitry Kravkov; +Cc: davem, netdev, vladz, eilong
Le mardi 12 octobre 2010 à 21:02 +0200, Dmitry Kravkov a écrit :
> Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
>
> Signed-off-by: Dmitry Kravkov <dmitry@broadcom.com>
> Signed-off-by: Vladislav Zolotarov <vladz@broadcom.com>
> ---
> drivers/net/bnx2x/bnx2x_main.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/bnx2x/bnx2x_main.c b/drivers/net/bnx2x/bnx2x_main.c
> index 7a9556b..ead524b 100644
> --- a/drivers/net/bnx2x/bnx2x_main.c
> +++ b/drivers/net/bnx2x/bnx2x_main.c
> @@ -2486,6 +2486,7 @@ void bnx2x_pf_init(struct bnx2x *bp)
> * if (is_eth_multi(bp))
> * flags |= FUNC_FLG_RSS;
> */
> + flags |= FUNC_FLG_RSS;
>
> /* function setup */
> if (flags & FUNC_FLG_RSS) {
Thanks, this solved the problem.
Tested-by: Eric Dumazet <eric.dumazet@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net-next] bnx2x: Fixing a typo: added a missing RSS enablement
2010-10-12 19:18 ` Eric Dumazet
@ 2010-10-12 19:31 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2010-10-12 19:31 UTC (permalink / raw)
To: eric.dumazet; +Cc: dmitry, netdev, vladz, eilong
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 12 Oct 2010 21:18:49 +0200
> Le mardi 12 octobre 2010 à 21:02 +0200, Dmitry Kravkov a écrit :
>> Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
>>
>> Signed-off-by: Dmitry Kravkov <dmitry@broadcom.com>
>> Signed-off-by: Vladislav Zolotarov <vladz@broadcom.com>
...
> Thanks, this solved the problem.
>
> Tested-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks guys.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] bnx2x: Fixing a typo: added a missing RSS enablement
2010-10-12 19:02 [PATCH net-next] bnx2x: Fixing a typo: added a missing RSS enablement Dmitry Kravkov
2010-10-12 19:18 ` Eric Dumazet
@ 2010-10-12 19:26 ` Joe Perches
2010-10-12 19:31 ` David Miller
1 sibling, 1 reply; 6+ messages in thread
From: Joe Perches @ 2010-10-12 19:26 UTC (permalink / raw)
To: Dmitry Kravkov; +Cc: davem, netdev, eric.dumazet, vladz, eilong
On Tue, 2010-10-12 at 21:02 +0200, Dmitry Kravkov wrote:
> Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
>
> Signed-off-by: Dmitry Kravkov <dmitry@broadcom.com>
> Signed-off-by: Vladislav Zolotarov <vladz@broadcom.com>
> ---
> drivers/net/bnx2x/bnx2x_main.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/bnx2x/bnx2x_main.c b/drivers/net/bnx2x/bnx2x_main.c
> index 7a9556b..ead524b 100644
> --- a/drivers/net/bnx2x/bnx2x_main.c
> +++ b/drivers/net/bnx2x/bnx2x_main.c
> @@ -2486,6 +2486,7 @@ void bnx2x_pf_init(struct bnx2x *bp)
> * if (is_eth_multi(bp))
> * flags |= FUNC_FLG_RSS;
> */
> + flags |= FUNC_FLG_RSS;
>
> /* function setup */
> if (flags & FUNC_FLG_RSS) {
Then the "if (flags & FUNC_FLG_RSS)" test should be removed.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net-next] bnx2x: Fixing a typo: added a missing RSS enablement
2010-10-12 19:26 ` Joe Perches
@ 2010-10-12 19:31 ` David Miller
2010-10-12 20:08 ` Vladislav Zolotarov
0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2010-10-12 19:31 UTC (permalink / raw)
To: joe; +Cc: dmitry, netdev, eric.dumazet, vladz, eilong
From: Joe Perches <joe@perches.com>
Date: Tue, 12 Oct 2010 12:26:19 -0700
> On Tue, 2010-10-12 at 21:02 +0200, Dmitry Kravkov wrote:
>> @@ -2486,6 +2486,7 @@ void bnx2x_pf_init(struct bnx2x *bp)
>> * if (is_eth_multi(bp))
>> * flags |= FUNC_FLG_RSS;
>> */
>> + flags |= FUNC_FLG_RSS;
>>
>> /* function setup */
>> if (flags & FUNC_FLG_RSS) {
>
> Then the "if (flags & FUNC_FLG_RSS)" test should be removed.
Yeah it probably should. If necessary it could be added back
later.
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH net-next] bnx2x: Fixing a typo: added a missing RSS enablement
2010-10-12 19:31 ` David Miller
@ 2010-10-12 20:08 ` Vladislav Zolotarov
0 siblings, 0 replies; 6+ messages in thread
From: Vladislav Zolotarov @ 2010-10-12 20:08 UTC (permalink / raw)
To: David Miller, joe@perches.com
Cc: Dmitry Kravkov, netdev@vger.kernel.org, eric.dumazet@gmail.com,
Eilon Greenstein
> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Tuesday, October 12, 2010 9:32 PM
> To: joe@perches.com
> Cc: Dmitry Kravkov; netdev@vger.kernel.org; eric.dumazet@gmail.com;
> Vladislav Zolotarov; Eilon Greenstein
> Subject: Re: [PATCH net-next] bnx2x: Fixing a typo: added a missing RSS
> enablement
>
> From: Joe Perches <joe@perches.com>
> Date: Tue, 12 Oct 2010 12:26:19 -0700
>
> > On Tue, 2010-10-12 at 21:02 +0200, Dmitry Kravkov wrote:
> >> @@ -2486,6 +2486,7 @@ void bnx2x_pf_init(struct bnx2x *bp)
> >> * if (is_eth_multi(bp))
> >> * flags |= FUNC_FLG_RSS;
> >> */
> >> + flags |= FUNC_FLG_RSS;
> >>
> >> /* function setup */
> >> if (flags & FUNC_FLG_RSS) {
> >
> > Then the "if (flags & FUNC_FLG_RSS)" test should be removed.
>
> Yeah it probably should. If necessary it could be added back
> later.
Thanks, Joe. We will consider removing this "if" and will post
an appropriate patch. Most likely in the close patch series we
have promised to respin... ;)
Thanks to all, guys.
vlad
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-10-12 20:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-12 19:02 [PATCH net-next] bnx2x: Fixing a typo: added a missing RSS enablement Dmitry Kravkov
2010-10-12 19:18 ` Eric Dumazet
2010-10-12 19:31 ` David Miller
2010-10-12 19:26 ` Joe Perches
2010-10-12 19:31 ` David Miller
2010-10-12 20:08 ` Vladislav Zolotarov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).