From: Joe Perches <joe@perches.com>
To: Denis Kirjanov <dkirjanov@kernel.org>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
Ben Hutchings <bhutchings@solarflare.com>,
Jeff Garzik <jgarzik@redhat.com>
Subject: Re: [PATCH -next] sundance: Add initial ethtool stats support
Date: Tue, 12 Oct 2010 13:57:19 -0700 [thread overview]
Message-ID: <1286917039.1117.101.camel@Joe-Laptop> (raw)
In-Reply-To: <4CB4C6E6.9090805@kernel.org>
On Wed, 2010-10-13 at 00:36 +0400, Denis Kirjanov wrote:
> diff --git a/drivers/net/sundance.c b/drivers/net/sundance.c
Hi Denis.
Just a few trivial misspellings of deffered -> deferred
> index 4283cc5..159f7e7 100644
> --- a/drivers/net/sundance.c
> +++ b/drivers/net/sundance.c
> @@ -363,6 +363,19 @@ struct netdev_private {
> dma_addr_t tx_ring_dma;
> dma_addr_t rx_ring_dma;
> struct timer_list timer; /* Media monitoring timer. */
> + /* ethtool extra stats */
> + struct {
> + u64 tx_multiple_collisions;
> + u64 tx_single_collisions;
> + u64 tx_late_collisions;
> + u64 tx_deffered;
> + u64 tx_deffered_excessive;
1
> + np->xstats.tx_deffered += ioread8(ioaddr + StatsTxDefer);
> + np->xstats.tx_deffered_excessive += ioread8(ioaddr + StatsTxXSDefer);
2
> +static const struct {
> + const char name[ETH_GSTRING_LEN];
> +} sundance_stats[] = {
> + { "tx_multiple_collisions" },
> + { "tx_single_collisions" },
> + { "tx_late_collisions" },
> + { "tx_deffered" },
> + { "tx_deffered_excessive" },
3
> + data[i++] = np->xstats.tx_deffered;
> + data[i++] = np->xstats.tx_deffered_excessive;
4
next prev parent reply other threads:[~2010-10-12 21:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-09 9:53 [PATCH -next] sundance: Add initial ethtool stats support Denis Kirjanov
2010-10-09 12:17 ` [PATCH net-next] sundance: get_stats proper locking Eric Dumazet
2010-10-09 16:24 ` David Miller
2010-10-09 12:33 ` [PATCH -next] sundance: Add initial ethtool stats support Eric Dumazet
2010-10-09 13:27 ` Ben Hutchings
2010-10-09 14:40 ` Denis Kirjanov
2010-10-09 19:41 ` Denis Kirjanov
2010-10-09 21:48 ` Jeff Garzik
2010-10-12 18:51 ` David Miller
2010-10-12 20:36 ` Denis Kirjanov
2010-10-12 20:57 ` Joe Perches [this message]
2010-10-13 6:06 ` Denis Kirjanov
2010-10-13 6:33 ` Eric Dumazet
2010-10-13 7:02 ` Denis Kirjanov
2010-10-13 10:28 ` Denis Kirjanov
2010-10-13 10:36 ` Eric Dumazet
2010-10-13 10:56 ` Denis Kirjanov
2010-10-13 19:44 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286917039.1117.101.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=dkirjanov@kernel.org \
--cc=eric.dumazet@gmail.com \
--cc=jgarzik@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox