Re: [PATCH v2] xps-mp: Transmit Packet Steering for multiqueue

[Eric Dumazet <eric.dumazet@gmail.com>]

Le mardi 12 octobre 2010 à 17:20 -0700, Tom Herbert a écrit :
> +#ifdef CONFIG_RPS
> +       struct kobject          kobj;
> +       struct netdev_queue     *first;
> +       atomic_t                count;
> +       struct xps_map          *xps_maps;
> +#endif 

Please put kobj at the end of this block, because its a big object (64
bytes)

+#ifdef CONFIG_RPS
> +       struct xps_map          *xps_maps;
> +       struct netdev_queue     *first;
> +       atomic_t                count;
> +       struct kobject          kobj;
> +#endif 
> 

This way, we only use one cache line to access hot path fields, instead
of two cache lines.



Tom, I believe you should split your patch in several parts, its really
too hard to review.


For example the netif_alloc_netdev_queues() stuff should be a patch on
its own, as this stuff was already discussed on netdev some days ago, so
that you could copy Ben and me on this one ;)

(Ie not allocating _tx in alloc_netdev_mq() but in register_netdevice())



Its also a good thing to give diffstat output :

 include/linux/netdevice.h |   28 +++
 include/linux/skbuff.h    |    1 
 net/core/dev.c            |  191 ++++++++++++++++------
 net/core/net-sysfs.c      |  305 +++++++++++++++++++++++++++++++++++-
 net/core/net-sysfs.h      |    3 
 net/ipv4/tcp_output.c     |    4 
 6 files changed, 471 insertions(+), 61 deletions(-)