From: nhorman@tuxdriver.com
To: netdev@vger.kernel.org
Cc: bonding-devel@lists.sourceforge.net, fubar@us.ibm.com,
davem@davemloft.net, andy@greyhouse.net, amwang@redhat.com,
nhorman@tuxdriver.com
Subject: [PATCH] bonding: various fixes for bonding, netpoll & netconsole (v2)
Date: Wed, 13 Oct 2010 08:35:29 -0400 [thread overview]
Message-ID: <1286973334-4339-1-git-send-email-nhorman@tuxdriver.com> (raw)
Version 2, taking teh following changes into account:
1) Moved tx blocking/checking macros to netpoll.h as suggested by amwang
2) Added tx blocking macro calls to sysfs paths, as they can deadlock in the
same way that the link monitoring paths can.
Summary:
A while ago we tried to enable netpoll on the bonding driver to enable
netconsole. That worked well in a steady state, but deadlocked frequently in
failover conditions due to some recursive lock-taking (as well as a few other
problems). I've gone through the driver, netconsole and netpoll code, fixed up
those deadlocks, and confirmed that, with this patch series, we can use
netconsole on bonding without deadlock in all bonding modes with all slaves,
even accross failovers. I've also fixed up some incidental bugs that I ran
across while looking through this code, as described in individual patches
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
next reply other threads:[~2010-10-13 12:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-13 12:35 nhorman [this message]
2010-10-13 12:35 ` [PATCH 1/5] Fix bonding drivers improper modification of netpoll structure nhorman
2010-10-13 12:35 ` [PATCH 2/5] Fix deadlock in bonding driver resulting from internal locking when using netpoll nhorman
2010-10-13 12:35 ` [PATCH 3/5] Fix napi poll for bonding driver nhorman
2010-10-13 12:35 ` [PATCH 4/5] Fix netconsole to not deadlock on rmmod nhorman
2010-10-13 12:35 ` [PATCH 5/5] Re-enable netpoll over bonding nhorman
2010-10-15 23:41 ` [PATCH] bonding: various fixes for bonding, netpoll & netconsole (v2) Flavio Leitner
2010-10-16 0:06 ` Neil Horman
2010-10-16 0:45 ` Flavio Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286973334-4339-1-git-send-email-nhorman@tuxdriver.com \
--to=nhorman@tuxdriver.com \
--cc=amwang@redhat.com \
--cc=andy@greyhouse.net \
--cc=bonding-devel@lists.sourceforge.net \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).