From: Joe Perches <joe@perches.com>
To: jeffrey.t.kirsher@intel.com
Cc: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
"Allan, Bruce W" <bruce.w.allan@intel.com>,
"Wyborny, Carolyn" <carolyn.wyborny@intel.com>,
"Skidmore, Donald C" <donald.c.skidmore@intel.com>,
"Rose, Gregory V" <gregory.v.rose@intel.com>,
"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>,
"Duyck, Alexander H" <alexander.h.duyck@intel.com>,
"Ronciak, John" <john.ronciak@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
e1000-devel <e1000-devel@lists.sourceforge.net>
Subject: Re: [RFC PATCH net-next] drivers/net Documentation/networking: Create directory intel_wired_lan
Date: Wed, 13 Oct 2010 22:57:37 -0700 [thread overview]
Message-ID: <1287035857.1117.528.camel@Joe-Laptop> (raw)
In-Reply-To: <1287032255.4113.14.camel@jtkirshe-MOBL1>
On Wed, 2010-10-13 at 21:57 -0700, Jeff Kirsher wrote:
> On Wed, 2010-10-13 at 15:28 -0700, Joe Perches wrote:
> Sorry I am not ignoring you, I was taking a closer look at your patch.
> > What regression testing would actually be done?
> The Makefile and Kconfig needs more work. I applied your patch and none
> of the Intel Wired drivers build.
Care to describe the Makefile/Kconfig issues you have seen?
I built it allyesconfig, defconfig, allmodconfig and allnoconfig.
Perhaps you need to use "git am foo" in a test branch instead
of "patch -p1 < foo" ?
> I am working on providing an updated RFC patch to resolve the
> Makefile/Kconfig issues I found and few other minor issues I have
> found.
Oh good.
cheers, Joe
next prev parent reply other threads:[~2010-10-14 5:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-10 20:42 [RFC PATCH net-next] drivers/net Documentation/networking: Create directory intel_wired_lan Joe Perches
2010-10-10 21:44 ` Stephen Hemminger
2010-10-11 0:41 ` Joe Perches
2010-10-11 23:52 ` Jeff Kirsher
2010-10-12 0:00 ` Joe Perches
2010-10-13 22:28 ` Joe Perches
2010-10-14 4:57 ` Jeff Kirsher
2010-10-14 5:57 ` Joe Perches [this message]
2010-10-14 9:34 ` Jeff Kirsher
2010-10-14 19:30 ` Joe Perches
2010-10-14 21:37 ` Michal Marek
2010-10-14 22:20 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287035857.1117.528.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=alexander.h.duyck@intel.com \
--cc=bruce.w.allan@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=donald.c.skidmore@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=gregory.v.rose@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox