Re: Bug#595265: linux-image-2.6.32-5-686: Nerwork card fails to come up again after suspend

Re: Bug#595265: linux-image-2.6.32-5-686: Nerwork card fails to come up again after suspend

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 526 bytes --]

Arnout Boelens reported that his RTL8111/8168B fails to link-up after
suspend and resume, both under Debian's kernel based on 2.6.32 and under
2.6.36-rc6.  Full details are at <http://bugs.debian.org/595265>, though
the log isn't very informative:

[31837.396594] PM: Finishing wakeup.
[31837.396597] Restarting tasks ... done.
[31840.267267] r8169: eth0: link down

Can you suggest how to investigate this further?

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: Bug#595265: linux-image-2.6.32-5-686: Nerwork card fails to come up again after suspend

[Francois Romieu]

Ben Hutchings <ben@decadent.org.uk> :
[...]
> Arnout Boelens reported that his RTL8111/8168B fails to link-up after
> suspend and resume, both under Debian's kernel based on 2.6.32 and under
> 2.6.36-rc6.  Full details are at <http://bugs.debian.org/595265>, though
> the log isn't very informative:
> 
> [31837.396594] PM: Finishing wakeup.
> [31837.396597] Restarting tasks ... done.
> [31840.267267] r8169: eth0: link down
> 
> Can you suggest how to investigate this further?

Something like the patch made by Stanislaw at :
https://bugzilla.redhat.com/show_bug.cgi?id=502974

-- 
Ueimor

Re: Bug#595265: linux-image-2.6.32-5-686: Nerwork card fails to come up again after suspend

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 1000 bytes --]

On Mon, 2010-10-18 at 23:45 +0200, Francois Romieu wrote:
> Ben Hutchings <ben@decadent.org.uk> :
> [...]
> > Arnout Boelens reported that his RTL8111/8168B fails to link-up after
> > suspend and resume, both under Debian's kernel based on 2.6.32 and under
> > 2.6.36-rc6.  Full details are at <http://bugs.debian.org/595265>, though
> > the log isn't very informative:
> > 
> > [31837.396594] PM: Finishing wakeup.
> > [31837.396597] Restarting tasks ... done.
> > [31840.267267] r8169: eth0: link down
> > 
> > Can you suggest how to investigate this further?
> 
> Something like the patch made by Stanislaw at :
> https://bugzilla.redhat.com/show_bug.cgi?id=502974

Thanks.

Arnout, please test the patch
<https://bugzilla.redhat.com/attachment.cgi?id=454034>, following the
instructions at
<http://kernel-handbook.alioth.debian.org/ch-common-tasks.html#s-common-official>.

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: Bug#595265: linux-image-2.6.32-5-686: Nerwork card fails to come up again after suspend

[Eric Dumazet]

Le lundi 18 octobre 2010 à 23:45 +0200, Francois Romieu a écrit :
> Ben Hutchings <ben@decadent.org.uk> :
> [...]
> > Arnout Boelens reported that his RTL8111/8168B fails to link-up after
> > suspend and resume, both under Debian's kernel based on 2.6.32 and under
> > 2.6.36-rc6.  Full details are at <http://bugs.debian.org/595265>, though
> > the log isn't very informative:
> > 
> > [31837.396594] PM: Finishing wakeup.
> > [31837.396597] Restarting tasks ... done.
> > [31840.267267] r8169: eth0: link down
> > 
> > Can you suggest how to investigate this further?
> 
> Something like the patch made by Stanislaw at :
> https://bugzilla.redhat.com/show_bug.cgi?id=502974
> 

Seems to be down at this moment, patch is also here (and included in
2.6.36-rc8 ) :

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=aeb19f6052b5e5c8a24aa444fbff73b84341beac

Bug#595265: linux-image-2.6.32-5-686: Nerwork card fails to come up again after suspend

[Francois Romieu]

Eric Dumazet <eric.dumazet@gmail.com> :
> Le lundi 18 octobre 2010 à 23:45 +0200, Francois Romieu a écrit :
[...]
> > Something like the patch made by Stanislaw at :
> > https://bugzilla.redhat.com/show_bug.cgi?id=502974
> > 
> 
> Seems to be down at this moment, patch is also here (and included in
> 2.6.36-rc8 ) :
> 
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=aeb19f6052b5e5c8a24aa444fbff73b84341beac

It's from the same author but it is not included in 2.6.36-stg yet :

Subject: [PATCH] r8169 init phy when resume

For unknown reasons some r8169 devices after resume operate at
100 Mb/s speed instead of 1000 Mb/s like before suspend. To fix
reset phy during resume.

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
---
 drivers/net/r8169.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index 17382c3..a4ce127 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -4847,6 +4847,9 @@ static int rtl8169_resume(struct device *device)
 {
 	struct pci_dev *pdev = to_pci_dev(device);
 	struct net_device *dev = pci_get_drvdata(pdev);
+	struct rtl8169_private *tp = netdev_priv(dev);
+
+	rtl8169_init_phy(dev, tp);
 
 	if (!netif_running(dev))
 		goto out;
-- 
1.7.1