From: Joe Perches <joe@perches.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>,
Jeff Garzik <jeff@garzik.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH] ethtool: add get permanent address option (v2)
Date: Mon, 18 Oct 2010 13:16:11 -0700 [thread overview]
Message-ID: <1287432971.2526.18.camel@Joe-Laptop> (raw)
In-Reply-To: <20101018131104.02681d60@nehalam>
On Mon, 2010-10-18 at 13:11 -0700, Stephen Hemminger wrote:
> diff --git a/ethtool.c b/ethtool.c
[]
> @@ -750,7 +758,8 @@ static void parse_cmdline(int argc, char **argp)
> (mode == MODE_SNTUPLE) ||
> (mode == MODE_GNTUPLE) ||
> (mode == MODE_PHYS_ID) ||
> - (mode == MODE_FLASHDEV)) {
> + (mode == MODE_FLASHDEV) |
> + (mode == MODE_PERMADDR)) {
One more vertical bar please.
next prev parent reply other threads:[~2010-10-18 20:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-18 18:41 [PATCH] ethtool: add get permanent address option Stephen Hemminger
2010-10-18 19:52 ` Ben Hutchings
2010-10-18 20:11 ` [PATCH] ethtool: add get permanent address option (v2) Stephen Hemminger
2010-10-18 20:16 ` Joe Perches [this message]
2010-11-16 23:12 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287432971.2526.18.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=bhutchings@solarflare.com \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox