Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Anders.Franzen@ericsson.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] ip6_tunnel dont update the mtu on the route.
Date: Tue, 19 Oct 2010 16:32:08 +0200	[thread overview]
Message-ID: <1287498728.2676.110.camel@edumazet-laptop> (raw)
In-Reply-To: <1287496247-24127-1-git-send-email-Anders.Franzen@ericsson.com>

Le mardi 19 octobre 2010 à 15:50 +0200, Anders.Franzen@ericsson.com a
écrit :
> From: Anders Franzen <anders.franzen@ericsson.com>
> 
> The ip6_tunnel device did not unset the flag,
> IFF_XMIT_DST_RELEASE. This will make the dev layer
> to release the dst before calling the tunnel.
> The tunnel will not update any mtu/pmtu info, since
> it does not have a dst on the skb.
> ---
>  net/ipv6/ip6_tunnel.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c
> index c2c0f89..38b9a56 100644
> --- a/net/ipv6/ip6_tunnel.c
> +++ b/net/ipv6/ip6_tunnel.c
> @@ -1371,6 +1371,7 @@ static void ip6_tnl_dev_setup(struct net_device *dev)
>  	dev->flags |= IFF_NOARP;
>  	dev->addr_len = sizeof(struct in6_addr);
>  	dev->features |= NETIF_F_NETNS_LOCAL;
> +	dev->priv_flags &= ~IFF_XMIT_DST_RELEASE;
>  }
>  
> 

Thanks for catching this Anders

Acked-by: Eric Dumazet <eric.dumazet@gmail.com>




  reply	other threads:[~2010-10-19 14:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-19 13:50 [PATCH] ip6_tunnel dont update the mtu on the route Anders.Franzen
2010-10-19 14:32 ` Eric Dumazet [this message]
2010-10-24 22:24   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1287498728.2676.110.camel@edumazet-laptop \
    --to=eric.dumazet@gmail.com \
    --cc=Anders.Franzen@ericsson.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox