From: nhorman@tuxdriver.com
To: netdev@vger.kernel.org
Cc: bonding-devel@lists.sourceforge.net, fubar@us.ibm.com,
davem@davemloft.net, andy@greyhouse.net, amwang@redhat.com,
nhorman@tuxdriver.com
Subject: [PATCH] bonding: minor cleanups to bond + netpoll
Date: Tue, 19 Oct 2010 13:04:24 -0400 [thread overview]
Message-ID: <1287507866-25156-1-git-send-email-nhorman@tuxdriver.com> (raw)
Testing that was onging when the the reset patchset to enable netpoll over
bonding revealed some minor corner cases that are worth correcting. In summary:
1) Remove netpoll tx blocking from bond_release_all. Its not needed and causes
some uglyness when removing the bonding module, in the form of a backtrace that
gets logged. blocking isn't needed in this path anyway as the netconsole is
already unregistered from us at this point
2) Remove my changes to napi_poll. Closer inspection of the bonding
poll_controller show that we wind up recursively calling the napi poll routines
for the slaves through sucsessive calls to netpoll_poll_dev. My origional
change is harmless, but its not really needed, so lets make the code simpler.
Further details available in the individual commit messages
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
next reply other threads:[~2010-10-19 17:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 17:04 nhorman [this message]
2010-10-19 17:04 ` [PATCH 1/2] Remove netpoll blocking from uninit path nhorman
2010-10-20 7:47 ` Cong Wang
2010-10-20 8:45 ` David Miller
2010-10-20 10:51 ` Neil Horman
2010-10-19 17:04 ` [PATCH 2/2] Revert napi_poll fix for bonding driver nhorman
2010-10-20 7:52 ` Cong Wang
2010-10-20 8:45 ` David Miller
2010-10-19 20:29 ` [PATCH] bonding: minor cleanups to bond + netpoll Andy Gospodarek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287507866-25156-1-git-send-email-nhorman@tuxdriver.com \
--to=nhorman@tuxdriver.com \
--cc=amwang@redhat.com \
--cc=andy@greyhouse.net \
--cc=bonding-devel@lists.sourceforge.net \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).