Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Simon Horman <horms@verge.net.au>
Cc: Hans Schillstrom <hans.schillstrom@ericsson.com>,
	lvs-devel@vger.kernel.org, netdev@vger.kernel.org,
	netfilter-devel@vger.kernel.org, ja@ssi.bg, wensong@linux-vs.org,
	daniel.lezcano@free.fr
Subject: Re: [RFC PATCH 5/9] ipvs network name space aware
Date: Thu, 21 Oct 2010 13:26:54 +0200	[thread overview]
Message-ID: <1287660414.6871.85.camel@edumazet-laptop> (raw)
In-Reply-To: <20101021111644.GA25555@verge.net.au>

Le jeudi 21 octobre 2010 à 13:16 +0200, Simon Horman a écrit :

> > @@ -2680,10 +2664,15 @@ static int ip_vs_genl_dump_services(struct sk_buff *skb,
> >  	int idx = 0, i;
> >  	int start = cb->args[0];
> >  	struct ip_vs_service *svc;
> > -
> > +	struct net *net = skb->sk->sk_net;
> 
> skb->sk->sk_net needs CONFIG_NS_NET.
> Is your plan for IPVS to unconditionally depend on CONFIG_NS_NET?
> It would be nice to avoid that, but I fear it will be too messy.
> 


struct net *net = sock_net(skb->sk);

is your friend ;)


--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2010-10-21 11:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-08 11:17 [RFC PATCH 5/9] ipvs network name space aware Hans Schillstrom
2010-10-20 15:21 ` Simon Horman
2010-10-21  7:35   ` Hans Schillstrom
2010-10-21  8:27     ` Horms
2010-10-21 11:16 ` Simon Horman
2010-10-21 11:26   ` Eric Dumazet [this message]
2010-10-21 11:49     ` Hans Schillstrom
2010-10-21 14:34       ` Simon Horman
2010-10-21 11:42   ` Hans Schillstrom
2010-10-21 22:56     ` Julian Anastasov
2010-10-22 19:05 ` Simon Horman
2010-10-26 13:07   ` Hans Schillstrom
2010-10-26 21:03     ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1287660414.6871.85.camel@edumazet-laptop \
    --to=eric.dumazet@gmail.com \
    --cc=daniel.lezcano@free.fr \
    --cc=hans.schillstrom@ericsson.com \
    --cc=horms@verge.net.au \
    --cc=ja@ssi.bg \
    --cc=lvs-devel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=wensong@linux-vs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox