From: Eric Dumazet <eric.dumazet@gmail.com>
To: emin ak <eminak71@gmail.com>
Cc: Jarek Poplawski <jarkao2@gmail.com>,
David Miller <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>,
netdev@vger.kernel.org, bugzilla-daemon@bugzilla.kernel.org,
bugme-daemon@bugzilla.kernel.org,
Anton Vorontsov <avorontsov@mvista.com>,
Andy Fleming <afleming@freescale.com>
Subject: Re: [PATCH] gianfar: Fix crashes on RX path (Was Re: [Bugme-new] [Bug 19692] New: linux-2.6.36-rc5 crash with gianfar ethernet at full line rate traffic)
Date: Fri, 22 Oct 2010 08:14:08 +0200 [thread overview]
Message-ID: <1287728048.9059.124.camel@edumazet-laptop> (raw)
In-Reply-To: <AANLkTimakJjwL9v2Ztpce3Xnjb_r5XB=rGoJc9pZKE12@mail.gmail.com>
Le vendredi 22 octobre 2010 à 08:42 +0300, emin ak a écrit :
> Hi Jarek;
>
> > Maybe for now let's try to get and see this type 1 again? Since the
> > recycle path is suspicious a bit to me, probably limiting memory or
> > slowing tx (maybe different mtus on eth0 and 1) under heavy multi cpu
> > load might help.
> >
>
> I'll do my best with your recommended test conditions. I have reserved
> a machine and two ports of hw packet generator, now we'll see if this
> error will occur again or not. (But I'am not sure if I want to see it
> again:)
Really this rx recycle affair is more than suspicious to me too.
Is it really worth the pain ?
Are MTU changes handled correctly ? ( must flush rx_recycle queue...)
Using a single rx_recycle queue in a supposed multiqueue driver makes
absolutely _no_ sense to me. This adds an artificial contention point.
next prev parent reply other threads:[~2010-10-22 6:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-19692-10286@https.bugzilla.kernel.org/>
2010-10-04 20:53 ` [Bugme-new] [Bug 19692] New: linux-2.6.36-rc5 crash with gianfar ethernet at full line rate traffic Andrew Morton
2010-10-08 9:24 ` Jarek Poplawski
2010-10-09 12:10 ` emin ak
2010-10-10 10:32 ` Jarek Poplawski
2010-10-15 8:58 ` Jarek Poplawski
2010-10-15 23:14 ` emin ak
2010-10-16 19:48 ` Jarek Poplawski
2010-10-19 6:44 ` emin ak
2010-10-19 10:06 ` [PATCH] gianfar: Fix crashes on RX path (Was Re: [Bugme-new] [Bug 19692] New: linux-2.6.36-rc5 crash with gianfar ethernet at full line rate traffic) Jarek Poplawski
2010-10-22 5:42 ` emin ak
2010-10-22 6:14 ` Eric Dumazet [this message]
2010-10-22 7:03 ` Jarek Poplawski
2010-10-22 6:11 ` Eric Dumazet
2010-10-22 6:52 ` Jarek Poplawski
2010-10-22 8:52 ` Jarek Poplawski
2010-10-26 17:42 ` [PATCH] gianfar: Fix crashes on RX path David Miller
2010-10-26 21:20 ` Jarek Poplawski
2010-10-26 21:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287728048.9059.124.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=afleming@freescale.com \
--cc=akpm@linux-foundation.org \
--cc=avorontsov@mvista.com \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=bugzilla-daemon@bugzilla.kernel.org \
--cc=davem@davemloft.net \
--cc=eminak71@gmail.com \
--cc=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox