From: Eric Dumazet <eric.dumazet@gmail.com>
To: leitao@linux.vnet.ibm.com
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] ehea: Fixing statistics
Date: Tue, 26 Oct 2010 20:48:40 +0200 [thread overview]
Message-ID: <1288118920.2652.4.camel@edumazet-laptop> (raw)
In-Reply-To: <1288116213-11801-1-git-send-email-leitao@linux.vnet.ibm.com>
Le mardi 26 octobre 2010 à 14:03 -0400, leitao@linux.vnet.ibm.com a
écrit :
> @@ -2296,6 +2314,7 @@ static int ehea_start_xmit(struct sk_buff *skb, struct net_device *dev)
>
> ehea_post_swqe(pr->qp, swqe);
> pr->tx_packets++;
> + pr->tx_bytes += skb->len;
>
> if (unlikely(atomic_read(&pr->swqe_avail) <= 1)) {
> spin_lock_irqsave(&pr->netif_queue, flags);
This seems very suspicious to me. Lets take a look at this driver.
ehea_xmit3() frees the skb.
Yet, you happily use skb after it... kaboom...
Note: driver already uses skb after its freeing, before your patch.
if (vlan_tx_tag_present(skb)) {
swqe->tx_control |= EHEA_SWQE_VLAN_INSERT;
swqe->vlan_tag = vlan_tx_tag_get(skb);
}
How can it works ?
next prev parent reply other threads:[~2010-10-26 18:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 18:03 [PATCH] ehea: Fixing statistics leitao
2010-10-26 18:48 ` Eric Dumazet [this message]
2010-10-27 5:21 ` [PATCH] ehea: fix use after free Eric Dumazet
2010-10-27 16:05 ` Breno Leitao
2010-10-27 18:39 ` David Miller
2010-10-27 18:45 ` [PATCH v2] ehea: Fixing statistics Breno Leitao
2010-10-27 18:53 ` Eric Dumazet
2010-10-27 21:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288118920.2652.4.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=leitao@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox