From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jeremy Jackson <jerj@coplanar.net>
Cc: netdev@vger.kernel.org
Subject: Re: Unwanted aliasing of UDP checksum failed error counter
Date: Tue, 26 Oct 2010 22:27:22 +0200 [thread overview]
Message-ID: <1288124842.2652.28.camel@edumazet-laptop> (raw)
In-Reply-To: <a2ae895d871551a9b3ded9ce3874fe28.squirrel@imap.coplanar.net>
Le mardi 26 octobre 2010 à 16:21 -0400, Jeremy Jackson a écrit :
> > Le mardi 26 octobre 2010 à 15:53 -0400, Jeremy Jackson a écrit :
> >> Trying to find source of packet loss on an 8node compute cluster, we
> >> find:
> >> (not in this example, but on the real cluster)
> >>
> >> in /proc/sys/net/snmp
> >> Udp: InDatagrams NoPorts InErrors OutDatagrams RcvbufErrors SndbufErrors
> >> Udp: 976460 1750 0 986795 0 0
> >>
> >> InErrors *and* RcvbufErrors both go up with full socket buffer, this has
> >> made troubleshooting our application more difficult. We were chasing
> >> UDP
> >> checksum problems, until we checked linux source code, and found
> >> aliasing.
> >>
> >> Is this done for assembly code efficiency? Any reason ENOMEM (ie socket
> >> buffer full) can't avoid aliasing to UDP checksum failed errors?
> >>
> >> in linux-source-2.6.32/net/ipv4/udp.c:__udp_queue_rcv_skb()
> >> ....
> >> /* Note that an ENOMEM error is charged twice */
> >> if (rc == -ENOMEM) {
> >> UDP_INC_STATS_BH(sock_net(sk),
> >> UDP_MIB_RCVBUFERRORS,
> >> is_udplite);
> >> atomic_inc(&sk->sk_drops);
> >> }
> >> goto drop;
> >> ...
> >> drop:
> >> UDP_INC_STATS_BH(sock_net(sk), UDP_MIB_INERRORS, is_udplite);
> >>
> >
> > In MIBS, there is no counter for UDP checksum errors
> >
> > So we use the standard UDP_MIB_INERRORS
>
> Yes, this part I understand, but what I don't understand is why ENOMEM
> errors *and* checksum errors both use the same counter, while ENOMEM has
> it's own already.
Because ENOMEM errors were handled in commit 81aa646c,
but _all_ errors must also be accounted in INERRORS, to be RFC
compliant.
[IPV4]: add the UdpSndbufErrors and UdpRcvbufErrors MIBs
If we add a new MIB counter for checksum errors, a bad checksum packet
will increment both this new counter and INERRORS.
next prev parent reply other threads:[~2010-10-26 20:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 19:53 Unwanted aliasing of UDP checksum failed error counter Jeremy Jackson
2010-10-26 20:13 ` Eric Dumazet
2010-10-26 20:21 ` Jeremy Jackson
2010-10-26 20:27 ` Eric Dumazet [this message]
2010-10-27 9:35 ` [PATCH] ipv6/udp: report SndbufErrors and RcvbufErrors Eric Dumazet
2010-10-30 23:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288124842.2652.28.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=jerj@coplanar.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox