From: Shirley Ma <mashirle@us.ibm.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/1] vhost: TX used buffer guest signal accumulation
Date: Thu, 28 Oct 2010 10:14:22 -0700 [thread overview]
Message-ID: <1288286062.11251.15.camel@localhost.localdomain> (raw)
In-Reply-To: <20101028052021.GD5599@redhat.com>
> Two ideas:
> 1. How about writing out used, just delaying the signal?
> This way we don't have to queue separately.
This improves some performance, but not as good as delaying
both used and signal. Since delaying used buffers combining
multiple small copies to a large copy, which saves more CPU
utilization and increased some BW.
> 2. How about flushing out queued stuff before we exit
> the handle_tx loop? That would address most of
> the spec issue.
The performance is almost as same as the previous patch. I will resubmit
the modified one, adding vhost_add_used_and_signal_n after handle_tx
loop for processing pending queue.
This patch was a part of modified macvtap zero copy which I haven't
submitted yet. I found this helped vhost TX in general. This pending
queue will be used by DMA done later, so I put it in vq instead of a
local variable in handle_tx.
Thanks
Shirley
next prev parent reply other threads:[~2010-10-28 17:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 21:58 [RFC PATCH 1/1] vhost: TX used buffer guest signal accumulation Shirley Ma
2010-10-28 4:40 ` Shirley Ma
2010-10-28 5:20 ` Michael S. Tsirkin
2010-10-28 15:24 ` Shirley Ma
2010-10-28 17:14 ` Shirley Ma [this message]
2010-10-29 8:10 ` Michael S. Tsirkin
2010-10-29 15:43 ` Shirley Ma
2010-10-30 20:06 ` Michael S. Tsirkin
2010-11-01 20:17 ` Shirley Ma
2010-11-03 10:48 ` Michael S. Tsirkin
2010-11-04 5:38 ` Shirley Ma
2010-11-04 9:30 ` Michael S. Tsirkin
2010-11-04 21:37 ` Shirley Ma
2010-10-28 19:32 ` Shirley Ma
2010-10-28 20:13 ` Shirley Ma
2010-10-28 21:04 ` Sridhar Samudrala
2010-10-28 21:40 ` Shirley Ma
2010-10-29 8:11 ` Michael S. Tsirkin
2010-10-29 8:12 ` Michael S. Tsirkin
2010-10-29 8:03 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288286062.11251.15.camel@localhost.localdomain \
--to=mashirle@us.ibm.com \
--cc=davem@davemloft.net \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).