From: Shirley Ma <mashirle@us.ibm.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/1] vhost: TX used buffer guest signal accumulation
Date: Thu, 28 Oct 2010 12:32:35 -0700 [thread overview]
Message-ID: <1288294355.11251.20.camel@localhost.localdomain> (raw)
In-Reply-To: <20101028052021.GD5599@redhat.com>
On Thu, 2010-10-28 at 07:20 +0200, Michael S. Tsirkin wrote:
> My concern is this can delay signalling for unlimited time.
> Could you pls test this with guests that do not have
> 2b5bbe3b8bee8b38bdc27dd9c0270829b6eb7eeb
> b0c39dbdc204006ef3558a66716ff09797619778
> that is 2.6.31 and older?
The patch only induces delay signaling unlimited time when there is no
TX packet to transmit. I thought TX signaling only noticing guest to
release the used buffers, anything else beside this?
I tested rhel5u5 guest (2.6.18 kernel), it works fine. I checked the two
commits log, I don't think this patch could cause any issue w/o these
two patches.
Also I found a big TX regression for old guest and new guest. For old
guest, I am able to get almost 11Gb/s for 2K message size, but for the
new guest kernel, I can only get 3.5 Gb/s with the patch and same host.
I will dig it why.
thanks
Shirley
next prev parent reply other threads:[~2010-10-28 19:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 21:58 [RFC PATCH 1/1] vhost: TX used buffer guest signal accumulation Shirley Ma
2010-10-28 4:40 ` Shirley Ma
2010-10-28 5:20 ` Michael S. Tsirkin
2010-10-28 15:24 ` Shirley Ma
2010-10-28 17:14 ` Shirley Ma
2010-10-29 8:10 ` Michael S. Tsirkin
2010-10-29 15:43 ` Shirley Ma
2010-10-30 20:06 ` Michael S. Tsirkin
2010-11-01 20:17 ` Shirley Ma
2010-11-03 10:48 ` Michael S. Tsirkin
2010-11-04 5:38 ` Shirley Ma
2010-11-04 9:30 ` Michael S. Tsirkin
2010-11-04 21:37 ` Shirley Ma
2010-10-28 19:32 ` Shirley Ma [this message]
2010-10-28 20:13 ` Shirley Ma
2010-10-28 21:04 ` Sridhar Samudrala
2010-10-28 21:40 ` Shirley Ma
2010-10-29 8:11 ` Michael S. Tsirkin
2010-10-29 8:12 ` Michael S. Tsirkin
2010-10-29 8:03 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288294355.11251.20.camel@localhost.localdomain \
--to=mashirle@us.ibm.com \
--cc=davem@davemloft.net \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).