From: Eric Dumazet <eric.dumazet@gmail.com>
To: Guo-Fu Tseng <cooldavid@cooldavid.org>
Cc: David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] jme: fix panic on load
Date: Sun, 31 Oct 2010 17:32:12 +0100 [thread overview]
Message-ID: <1288542732.2660.57.camel@edumazet-laptop> (raw)
In-Reply-To: <20101031163428.M61655@cooldavid.org>
Le lundi 01 novembre 2010 à 00:39 +0800, Guo-Fu Tseng a écrit :
> Can this patch be modified to move the netif_stop_queue()
> after register_netdev() ?
> It seems the __QUEUE_STATE_XOFF is not set after the register_netdev.
> The tx_queue was kcalloc() ed without touching state flags.
>
Real question is : why this netif_stop_queue() was needed at the first
place ?
We believe (David and others), that using before ndo_open() is useless
or a sign of design error.
http://www.spinics.net/lists/netdev/msg145481.html
Refs: commit c117e4a2bb4911
If your driver doesnt work after my change, then another patch is
needed, but not using netif_stop_queue() right after register_netdev()
prev parent reply other threads:[~2010-10-31 16:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-31 15:46 [PATCH] jme: fix panic on load Eric Dumazet
2010-10-31 16:34 ` David Miller
2010-10-31 16:39 ` Guo-Fu Tseng
2010-10-31 16:26 ` David Miller
2010-11-01 11:22 ` Guo-Fu Tseng
2010-10-31 16:32 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288542732.2660.57.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=cooldavid@cooldavid.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox