* [PATCH] bluetooth: hidp: fix information leak to userland
@ 2010-10-30 14:26 Vasiliy Kulikov
[not found] ` <1288448791-6009-1-git-send-email-segooon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Vasiliy Kulikov @ 2010-10-30 14:26 UTC (permalink / raw)
To: kernel-janitors
Cc: Marcel Holtmann, Gustavo F. Padovan, David S. Miller, Jiri Kosina,
Michael Poole, Bastien Nocera, linux-bluetooth, netdev,
linux-kernel
Structure hidp_conninfo is copied to userland with version, product,
vendor and name fields unitialized if both session->input and session->hid
are NULL. It leads to leaking of contents of kernel stack memory.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
---
Compile tested.
net/bluetooth/hidp/core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c
index c0ee8b3..29544c2 100644
--- a/net/bluetooth/hidp/core.c
+++ b/net/bluetooth/hidp/core.c
@@ -107,6 +107,7 @@ static void __hidp_unlink_session(struct hidp_session *session)
static void __hidp_copy_session(struct hidp_session *session, struct hidp_conninfo *ci)
{
+ memset(ci, 0, sizeof(*ci));
bacpy(&ci->bdaddr, &session->bdaddr);
ci->flags = session->flags;
@@ -115,7 +116,6 @@ static void __hidp_copy_session(struct hidp_session *session, struct hidp_connin
ci->vendor = 0x0000;
ci->product = 0x0000;
ci->version = 0x0000;
- memset(ci->name, 0, 128);
if (session->input) {
ci->vendor = session->input->id.vendor;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <1288448791-6009-1-git-send-email-segooon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH] bluetooth: hidp: fix information leak to userland [not found] ` <1288448791-6009-1-git-send-email-segooon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2010-11-02 15:36 ` Marcel Holtmann 2010-11-03 18:37 ` Gustavo F. Padovan 0 siblings, 1 reply; 3+ messages in thread From: Marcel Holtmann @ 2010-11-02 15:36 UTC (permalink / raw) To: Vasiliy Kulikov Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA, Gustavo F. Padovan, David S. Miller, Jiri Kosina, Michael Poole, Bastien Nocera, linux-bluetooth-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA Hi Vasiliy, > Structure hidp_conninfo is copied to userland with version, product, > vendor and name fields unitialized if both session->input and session->hid > are NULL. It leads to leaking of contents of kernel stack memory. > > Signed-off-by: Vasiliy Kulikov <segooon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Acked-by: Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org> Regards Marcel ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bluetooth: hidp: fix information leak to userland 2010-11-02 15:36 ` Marcel Holtmann @ 2010-11-03 18:37 ` Gustavo F. Padovan 0 siblings, 0 replies; 3+ messages in thread From: Gustavo F. Padovan @ 2010-11-03 18:37 UTC (permalink / raw) To: Marcel Holtmann Cc: Vasiliy Kulikov, kernel-janitors-u79uwXL29TY76Z2rM5mHXA, David S. Miller, Jiri Kosina, Michael Poole, Bastien Nocera, linux-bluetooth-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA * Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org> [2010-11-02 16:36:29 +0100]: > Hi Vasiliy, > > > Structure hidp_conninfo is copied to userland with version, product, > > vendor and name fields unitialized if both session->input and session->hid > > are NULL. It leads to leaking of contents of kernel stack memory. > > > > Signed-off-by: Vasiliy Kulikov <segooon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > > Acked-by: Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org> Applied, thanks. -- Gustavo F. Padovan ProFUSION embedded systems - http://profusion.mobi ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-11-03 18:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-30 14:26 [PATCH] bluetooth: hidp: fix information leak to userland Vasiliy Kulikov
[not found] ` <1288448791-6009-1-git-send-email-segooon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-11-02 15:36 ` Marcel Holtmann
2010-11-03 18:37 ` Gustavo F. Padovan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).