From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Jesse Gross <jesse@nicira.com>
Cc: David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>
Subject: Re: [PATCH 2/2] igb: Don't depend on vlan group for receive size.
Date: Wed, 03 Nov 2010 07:55:59 -0700 [thread overview]
Message-ID: <1288796159.3663.1.camel@jtkirshe-MOBL1> (raw)
In-Reply-To: <1288464591-31528-2-git-send-email-jesse@nicira.com>
[-- Attachment #1: Type: text/plain, Size: 676 bytes --]
On Sat, 2010-10-30 at 11:49 -0700, Jesse Gross wrote:
> The igb driver currently sets its maximum receive size based on
> whether a vlan group is configured. However, this causes it to
> completely drop MTU sized vlan packets when there is no vlan
> group, preventing them from showing up in tcpdump, etc.
>
> Signed-off-by: Jesse Gross <jesse@nicira.com>
> CC: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> CC: Jesse Brandeburg <jesse.brandeburg@intel.com>
> CC: PJ Waskiewicz <peter.p.waskiewicz.jr@intel.com>
> ---
> drivers/net/igb/igb_main.c | 5 +----
> 1 files changed, 1 insertions(+), 4 deletions(-)
Thanks, I have added this patch to my queue.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2010-11-03 14:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-30 18:49 [PATCH 1/2] ixgb: Don't check for vlan group on transmit Jesse Gross
2010-10-30 18:49 ` [PATCH 2/2] igb: Don't depend on vlan group for receive size Jesse Gross
2010-11-03 14:55 ` Jeff Kirsher [this message]
2010-11-03 14:55 ` [PATCH 1/2] ixgb: Don't check for vlan group on transmit Jeff Kirsher
2010-11-05 19:11 ` Jeff Kirsher
2010-11-05 19:56 ` Jesse Gross
2010-11-05 20:06 ` Jeff Kirsher
2010-11-05 22:30 ` Duyck, Alexander H
2010-11-08 19:59 ` Jesse Gross
2010-11-30 22:33 ` Jesse Gross
2010-11-30 22:52 ` Tantilov, Emil S
2010-12-01 17:40 ` Duyck, Alexander H
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288796159.3663.1.camel@jtkirshe-MOBL1 \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=jesse.brandeburg@intel.com \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).