netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: michael@ellerman.id.au
Cc: netdev@vger.kernel.org
Subject: Re: Freeing alive fib_info caused by ebc0ffae5
Date: Thu, 04 Nov 2010 11:30:26 +0100	[thread overview]
Message-ID: <1288866626.2659.71.camel@edumazet-laptop> (raw)
In-Reply-To: <1288866186.30549.10.camel@concordia>

Le jeudi 04 novembre 2010 à 21:23 +1100, Michael Ellerman a écrit :
> Hi all,
> 
> I'm running Linus' latest or thereabouts (ff8b16d), and I'm seeing
> "Freeing alive fib_info" messages, from free_fib_info().
> 
> Actually I only get one per boot, when network interfaces come up.
> Seemingly related I am getting refcount problems when I shutdown, ie.
> unregister_netdevice() sees a usage count of 1, which never decrements.
> 
> Bisect says it's ebc0ffae5 which causes the problem, or makes it appear.
> 
>     fib: RCU conversion of fib_lookup()
>     
>     fib_lookup() converted to be called in RCU protected context, no
>     reference taken and released on a contended cache line (fib_clntref)
>     
> 
> Is this a bug in that commit, or a driver bug exposed?

Hi Michael, thanks for the report (and painful bisection I guess)

Thats hard to say... Is it reproductable on my machine ?

Thanks



  reply	other threads:[~2010-11-04 10:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-04 10:23 Freeing alive fib_info caused by ebc0ffae5 Michael Ellerman
2010-11-04 10:30 ` Eric Dumazet [this message]
2010-11-04 10:46   ` Eric Dumazet
2010-11-04 11:21   ` Eric Dumazet
2010-11-04 11:23     ` Michael Ellerman
2010-11-04 11:35     ` Michael Ellerman
2010-11-04 19:06       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1288866626.2659.71.camel@edumazet-laptop \
    --to=eric.dumazet@gmail.com \
    --cc=michael@ellerman.id.au \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).