From: Michael Ellerman <michael@ellerman.id.au>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: Freeing alive fib_info caused by ebc0ffae5
Date: Thu, 04 Nov 2010 22:23:51 +1100 [thread overview]
Message-ID: <1288869831.30549.12.camel@concordia> (raw)
In-Reply-To: <1288869699.2659.77.camel@edumazet-laptop>
[-- Attachment #1: Type: text/plain, Size: 1295 bytes --]
On Thu, 2010-11-04 at 12:21 +0100, Eric Dumazet wrote:
> Le jeudi 04 novembre 2010 à 11:30 +0100, Eric Dumazet a écrit :
> > Le jeudi 04 novembre 2010 à 21:23 +1100, Michael Ellerman a écrit :
> > > Hi all,
> > >
> > > I'm running Linus' latest or thereabouts (ff8b16d), and I'm seeing
> > > "Freeing alive fib_info" messages, from free_fib_info().
> > >
> > > Actually I only get one per boot, when network interfaces come up.
> > > Seemingly related I am getting refcount problems when I shutdown, ie.
> > > unregister_netdevice() sees a usage count of 1, which never decrements.
> > >
> > > Bisect says it's ebc0ffae5 which causes the problem, or makes it appear.
> > >
> > > fib: RCU conversion of fib_lookup()
> > >
> > > fib_lookup() converted to be called in RCU protected context, no
> > > reference taken and released on a contended cache line (fib_clntref)
> > >
> > >
> > > Is this a bug in that commit, or a driver bug exposed?
> >
> > Hi Michael, thanks for the report (and painful bisection I guess)
> >
> > Thats hard to say... Is it reproductable on my machine ?
> >
>
> Hmm, a review of the code spotted a bug in fib_result_assign()
Aha, I was just adding some debug in there. Let me test the patch.
cheers
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2010-11-04 11:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-04 10:23 Freeing alive fib_info caused by ebc0ffae5 Michael Ellerman
2010-11-04 10:30 ` Eric Dumazet
2010-11-04 10:46 ` Eric Dumazet
2010-11-04 11:21 ` Eric Dumazet
2010-11-04 11:23 ` Michael Ellerman [this message]
2010-11-04 11:35 ` Michael Ellerman
2010-11-04 19:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288869831.30549.12.camel@concordia \
--to=michael@ellerman.id.au \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox