From: Eric Dumazet <eric.dumazet@gmail.com>
To: Joakim Tjernlund <joakim.tjernlund@transmode.se>
Cc: netdev@vger.kernel.org, Thomas Graf <tgraf@infradead.org>
Subject: Re: ping -I eth1 ....
Date: Fri, 05 Nov 2010 16:06:54 +0100 [thread overview]
Message-ID: <1288969614.2882.590.camel@edumazet-laptop> (raw)
In-Reply-To: <OF6C6C2970.245A64ED-ONC12577D2.00518CF6-C12577D2.00522AAD@transmode.se>
Le vendredi 05 novembre 2010 à 15:57 +0100, Joakim Tjernlund a écrit :
> Eric Dumazet <eric.dumazet@gmail.com> wrote on 2010/11/05 15:34:25:
> t be a reason why in many places we only test (dev->flags &
> > IFF_UP), and _never_ netif_oper_up() (only in dev_get_flags() to export
> > it at userspace)
>
> Hopefully most of that is legacy or just plain wrong? Unless
> someone can say why only test IFF_UP one should consider changing them.
>
Most of the places are hot path.
You dont want to replace one test by four tests.
_This_ would be wrong :)
next prev parent reply other threads:[~2010-11-05 15:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-05 13:14 ping -I eth1 Joakim Tjernlund
2010-11-05 13:36 ` Eric Dumazet
2010-11-05 14:01 ` Joakim Tjernlund
2010-11-05 14:25 ` Thomas Graf
2010-11-05 14:34 ` Eric Dumazet
2010-11-05 14:53 ` Thomas Graf
2010-11-05 15:04 ` Joakim Tjernlund
2010-11-05 15:45 ` Joakim Tjernlund
2010-11-05 14:57 ` Joakim Tjernlund
2010-11-05 15:06 ` Eric Dumazet [this message]
2010-11-05 15:54 ` Joakim Tjernlund
2010-11-05 20:31 ` Thomas Graf
2010-11-06 9:42 ` Joakim Tjernlund
[not found] ` <OF921B3329.67FE598A-ONC12577D3.0033387A-C12577D3.00355AC4@LocalDomain>
2010-11-09 19:33 ` Joakim Tjernlund
[not found] ` <OFC0986D69.B0E22D17-ONC12577D6.006B4A38-C12577D6.006B72F9@LocalDomain>
2010-11-17 9:29 ` Joakim Tjernlund
2010-11-17 9:51 ` Eric Dumazet
2010-11-17 10:09 ` Joakim Tjernlund
2010-11-17 10:23 ` Eric Dumazet
2010-11-17 14:03 ` Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288969614.2882.590.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=joakim.tjernlund@transmode.se \
--cc=netdev@vger.kernel.org \
--cc=tgraf@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox