netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guillaume Chazarain <guichaz@gmail.com>
To: davem@davemloft.net, netdev@vger.kernel.org
Cc: Guillaume Chazarain <guichaz@gmail.com>
Subject: [PATCH 1/2] skge: Remove tx queue stopping in skge_devinit()
Date: Sat,  6 Nov 2010 17:39:31 +0100	[thread overview]
Message-ID: <1289061572-5029-1-git-send-email-guichaz@gmail.com> (raw)

After e6484930d7c73d324bccda7d43d131088da697b9: net: allocate tx queues in register_netdevice
It causes an Oops at skge_probe() time.

Signed-off-by: Guillaume Chazarain <guichaz@gmail.com>
---
 drivers/net/skge.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/net/skge.c b/drivers/net/skge.c
index bfec2e0..220e039 100644
--- a/drivers/net/skge.c
+++ b/drivers/net/skge.c
@@ -3858,7 +3858,6 @@ static struct net_device *skge_devinit(struct skge_hw *hw, int port,
 
 	/* device is off until link detection */
 	netif_carrier_off(dev);
-	netif_stop_queue(dev);
 
 	return dev;
 }
-- 
1.7.1


             reply	other threads:[~2010-11-06 16:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-06 16:39 Guillaume Chazarain [this message]
2010-11-06 16:39 ` [PATCH 2/2] net: Detect and ignore netif_stop_queue() calls before register_netdev() Guillaume Chazarain
2010-11-08 20:19   ` David Miller
2010-11-08 20:19 ` [PATCH 1/2] skge: Remove tx queue stopping in skge_devinit() David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1289061572-5029-1-git-send-email-guichaz@gmail.com \
    --to=guichaz@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).