netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Rosenberg <drosenberg@vsecurity.com>
To: chas3@users.sourceforge.net
Cc: Andi Kleen <andi@firstfloor.org>, Ted Ts'o <tytso@mit.edu>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"kuznet@ms2.inr.ac.ru" <kuznet@ms2.inr.ac.ru>,
	"pekkas@netcore.fi" <pekkas@netcore.fi>,
	"jmorris@namei.org" <jmorris@namei.org>,
	"yoshfuji@linux-ipv6.org" <yoshfuji@linux-ipv6.org>,
	"kaber@trash.net" <kaber@trash.net>,
	"remi.denis-courmont@nokia.com" <remi.denis-courmont@nokia.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"security@kernel.org" <security@kernel.org>
Subject: Re: [Security] [SECURITY] Fix leaking of kernel heap addresses via /proc
Date: Sun, 07 Nov 2010 18:27:36 -0500	[thread overview]
Message-ID: <1289172456.3090.184.camel@Dan> (raw)
In-Reply-To: <201011072248.oA7MmjKg025857@cmf.nrl.navy.mil>

Based on the feedback so far, I think a few things need to be worked
out.  Firstly, I'm going to separate out printk leaks as an issue to be
worked on at a later time - it seems there is some interest in
evaluating whether dmesg should be restricted, but that is out of scope
of my plans for this patch series.

That leaves the /proc leakage.  I don't think XOR-ing is a viable
option, since it would be relatively easy to infer the constant value.
The criticism raised so far is that cutting out the pointers entirely
results in the omission of potentially useful debugging information.  I
see two viable options to address this: either print out or omit
addresses based on privileges (CAP_NET_ADMIN, for example), or have it
controllable via sysctl.  I'm leaning towards the sysctl
option...thoughts?

-Dan


  parent reply	other threads:[~2010-11-07 23:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-06 20:11 [SECURITY] Fix leaking of kernel heap addresses via /proc Dan Rosenberg
2010-11-06 20:50 ` [Security] " Linus Torvalds
2010-11-06 23:48   ` Ted Ts'o
2010-11-07 21:52     ` Andi Kleen
2010-11-07 22:48       ` Chas Williams (CONTRACTOR)
2010-11-07 23:14         ` Andi Kleen
2010-11-07 23:22         ` Linus Torvalds
2010-11-07 23:29           ` Andi Kleen
2010-11-07 23:27         ` Dan Rosenberg [this message]
2010-11-07 23:56           ` Andi Kleen
2010-11-08  2:01             ` David Miller
2010-11-08  7:33               ` Eric Dumazet
2010-11-08  9:43                 ` Andi Kleen
2010-11-08 10:14                   ` Eric Dumazet
2010-11-06 23:57   ` David Miller
2010-11-07 10:28     ` Oliver Hartkopp
2010-11-07 17:11       ` Ben Hutchings
2010-11-08  1:00     ` Willy Tarreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1289172456.3090.184.camel@Dan \
    --to=drosenberg@vsecurity.com \
    --cc=andi@firstfloor.org \
    --cc=chas3@users.sourceforge.net \
    --cc=davem@davemloft.net \
    --cc=jmorris@namei.org \
    --cc=kaber@trash.net \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@vger.kernel.org \
    --cc=pekkas@netcore.fi \
    --cc=remi.denis-courmont@nokia.com \
    --cc=security@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).