From: Eric Dumazet <eric.dumazet@gmail.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: David Miller <davem@davemloft.net>,
sf-linux-drivers <linux-net-drivers@solarflare.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: ip_summed setting for TCP pure-ACK packets
Date: Mon, 08 Nov 2010 17:56:06 +0100 [thread overview]
Message-ID: <1289235366.15376.3.camel@edumazet-laptop> (raw)
In-Reply-To: <1289234113.2222.20.camel@achroite.uk.solarflarecom.com>
Le lundi 08 novembre 2010 à 16:35 +0000, Ben Hutchings a écrit :
> As we discussed at LPC:
>
> Current controllers handled by the sfc driver have a per-queue (rather
> than per-packet) option for checksum generation. Currently pure-ACK
> packets sent by TCP have ip_summed == CHECKSUM_NONE and we must send
> them on hardware queues with checksum generation disabled. To support
> this, we allocate 2 hardware queues per core TX queue.
>
> To reduce the risk of reordering (and possibly the number of hardware TX
> queues required), it would be helpful for TCP to set ip_summed ==
> CHECKSUM_PARTIAL on pure-ACK packets when the output device is known to
> support checksum generation.
>
> Ben.
>
Hmm
Do you mean commit 2e8e18ef52e7dd1af0a3bd1 is not enough ?
next prev parent reply other threads:[~2010-11-08 16:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-08 16:35 ip_summed setting for TCP pure-ACK packets Ben Hutchings
2010-11-08 16:56 ` Eric Dumazet [this message]
2010-11-09 16:24 ` Ben Hutchings
2010-11-09 16:28 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289235366.15376.3.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox