From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: greearb@candelatech.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net/dst: dst_dev_event() called after other notifiers
Date: Wed, 10 Nov 2010 06:57:11 +0100 [thread overview]
Message-ID: <1289368631.2700.21.camel@edumazet-laptop> (raw)
In-Reply-To: <20101109.114853.193732360.davem@davemloft.net>
Le mardi 09 novembre 2010 à 11:48 -0800, David Miller a écrit :
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Tue, 09 Nov 2010 20:37:55 +0100
>
> > [PATCH] net/dst: dst_dev_event() called after other notifiers
>
> Nice, applied.
>
> However, I had to apply this by hand:
>
> > static struct notifier_block dst_dev_notifier = {
> > .notifier_call = dst_dev_event,
> > + .priority = -10, /* must be called after other network notifiers */
> > };
>
> The character after ".notifier_call" in my tree is a TAB character but
> in your patch it is a sequence of spaces. This isn't looking like the
> usual email corruption, because the leading TAB characters on these
> lines are properly there.
>
> Please figure out why this happened so that it doesn't repeat in
> future patches :-)
>
I am very sorry David, I had to run yesterday night and did a stupid
hand editing right before doing so. It was a human error, not a tool
error. Next time, I'll delay the patch to next day :)
Thanks !
prev parent reply other threads:[~2010-11-10 5:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 0:20 Takes > 1 second to delete macvlan with global IPv6 address on it Ben Greear
2010-11-09 6:15 ` Eric Dumazet
2010-11-09 19:37 ` [PATCH] net/dst: dst_dev_event() called after other notifiers Eric Dumazet
2010-11-09 19:48 ` David Miller
2010-11-09 20:11 ` Ben Greear
2010-11-10 5:57 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289368631.2700.21.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=greearb@candelatech.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox