From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jesse Gross <jesse@nicira.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH net-next-2.6] vlan: lockless transmit path
Date: Thu, 11 Nov 2010 18:52:58 +0100 [thread overview]
Message-ID: <1289497978.17691.1582.camel@edumazet-laptop> (raw)
In-Reply-To: <AANLkTikBkUNfrfSZkoVd1xzisD3jgg5kVUUZC45gNpde@mail.gmail.com>
Le jeudi 11 novembre 2010 à 09:40 -0800, Jesse Gross a écrit :
> If we're only allocating a single queue then we should also drop
> vlan_dev_select_queue() and the netdev_ops that call it. If the
> underlying device is multiqueue and has its own select_queue function
> then it can pick a queue number that is larger than what the vlan
> device has. The problem will be caught by dev_cap_txqueue() but it's
> not right and it would also be nice to get rid of half of those
> netdev_ops.
Hmm, you refer to old kernels dont you ?
My patch is for net-next
The plan is that after last Tom Herbert patches, dev_pick_tx() wont
call do_select_queue() on mono queue device.
http://patchwork.ozlabs.org/patch/70369/
This logicaly is a second cleanup patch I believe.
next prev parent reply other threads:[~2010-11-11 17:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-11 9:42 [PATCH net-next-2.6] vlan: lockless transmit path Eric Dumazet
2010-11-11 17:40 ` Jesse Gross
2010-11-11 17:52 ` Eric Dumazet [this message]
2010-11-11 18:56 ` Jesse Gross
2010-11-11 19:42 ` [PATCH net-next-2.6] vlan: remove ndo_select_queue() logic Eric Dumazet
2010-11-11 22:24 ` Jesse Gross
2010-11-12 15:50 ` Patrick McHardy
2010-11-16 19:24 ` David Miller
2010-11-16 19:54 ` Eric Dumazet
2010-11-17 4:12 ` John Fastabend
2010-11-16 19:24 ` [PATCH net-next-2.6] vlan: lockless transmit path David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289497978.17691.1582.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=jesse@nicira.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox