Re: [PATCH net-next-2.6] bridge: add __rcu annotations

Stephen Hemminger
2010-11-13T17:39:28Z

On Sat, 13 Nov 2010 09:15:28 +0100
Eric Dumazet <eric.dumazet@gmail.com> wrote:

> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 578debb..ffbd177 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -996,7 +996,10 @@ struct net_device {
> #endif
>
> rx_handler_func_t *rx_handler;
> - void *rx_handler_data;
> + union {
> + void *rx_handler_data;
> + struct net_bridge_port __rcu *br_port_rcu;
> + };
>
> struct netdev_queue __rcu *ingress_queue;

I don't like making the generic hook typed again.
We don't do this for other callbacks, timers, workqueues, ...
Why is it necessary for RCU notation.

--