* [PATCH] net: bnx2x: fix error value sign
@ 2010-11-14 20:08 Vasiliy Kulikov
2010-11-14 20:26 ` Eilon Greenstein
2010-11-14 20:29 ` Eric Dumazet
0 siblings, 2 replies; 5+ messages in thread
From: Vasiliy Kulikov @ 2010-11-14 20:08 UTC (permalink / raw)
To: kernel-janitors; +Cc: Eilon Greenstein, netdev, linux-kernel
bnx2x_init_one() should return negative value on error.
By mistake it returns ENODEV instead of -ENODEV.
Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
---
Compile tested.
drivers/net/bnx2x/bnx2x_main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/bnx2x/bnx2x_main.c b/drivers/net/bnx2x/bnx2x_main.c
index 4a6f0ea..be52edc 100644
--- a/drivers/net/bnx2x/bnx2x_main.c
+++ b/drivers/net/bnx2x/bnx2x_main.c
@@ -9064,7 +9064,7 @@ static int __devinit bnx2x_init_one(struct pci_dev *pdev,
default:
pr_err("Unknown board_type (%ld), aborting\n",
ent->driver_data);
- return ENODEV;
+ return -ENODEV;
}
cid_count += CNIC_CONTEXT_USE;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] net: bnx2x: fix error value sign
2010-11-14 20:08 [PATCH] net: bnx2x: fix error value sign Vasiliy Kulikov
@ 2010-11-14 20:26 ` Eilon Greenstein
2010-11-14 20:29 ` Eric Dumazet
1 sibling, 0 replies; 5+ messages in thread
From: Eilon Greenstein @ 2010-11-14 20:26 UTC (permalink / raw)
To: Vasiliy Kulikov
Cc: kernel-janitors@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
On Sun, 2010-11-14 at 12:08 -0800, Vasiliy Kulikov wrote:
> bnx2x_init_one() should return negative value on error.
> By mistake it returns ENODEV instead of -ENODEV.
>
> Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
Thanks Vasiliy!
Acked-by: Eilon Greenstein <eilong@broadcom.com>
> ---
> Compile tested.
>
> drivers/net/bnx2x/bnx2x_main.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/bnx2x/bnx2x_main.c b/drivers/net/bnx2x/bnx2x_main.c
> index 4a6f0ea..be52edc 100644
> --- a/drivers/net/bnx2x/bnx2x_main.c
> +++ b/drivers/net/bnx2x/bnx2x_main.c
> @@ -9064,7 +9064,7 @@ static int __devinit bnx2x_init_one(struct pci_dev *pdev,
> default:
> pr_err("Unknown board_type (%ld), aborting\n",
> ent->driver_data);
> - return ENODEV;
> + return -ENODEV;
> }
>
> cid_count += CNIC_CONTEXT_USE;
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] net: bnx2x: fix error value sign
2010-11-14 20:08 [PATCH] net: bnx2x: fix error value sign Vasiliy Kulikov
2010-11-14 20:26 ` Eilon Greenstein
@ 2010-11-14 20:29 ` Eric Dumazet
2010-11-14 20:32 ` Eric Dumazet
1 sibling, 1 reply; 5+ messages in thread
From: Eric Dumazet @ 2010-11-14 20:29 UTC (permalink / raw)
To: Vasiliy Kulikov; +Cc: kernel-janitors, Eilon Greenstein, netdev, linux-kernel
Le dimanche 14 novembre 2010 à 23:08 +0300, Vasiliy Kulikov a écrit :
> bnx2x_init_one() should return negative value on error.
> By mistake it returns ENODEV instead of -ENODEV.
>
> Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
> ---
> Compile tested.
>
> drivers/net/bnx2x/bnx2x_main.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/bnx2x/bnx2x_main.c b/drivers/net/bnx2x/bnx2x_main.c
> index 4a6f0ea..be52edc 100644
> --- a/drivers/net/bnx2x/bnx2x_main.c
> +++ b/drivers/net/bnx2x/bnx2x_main.c
> @@ -9064,7 +9064,7 @@ static int __devinit bnx2x_init_one(struct pci_dev *pdev,
> default:
> pr_err("Unknown board_type (%ld), aborting\n",
> ent->driver_data);
> - return ENODEV;
> + return -ENODEV;
> }
>
> cid_count += CNIC_CONTEXT_USE;
I remember sending same patch in the past... it was lost somehow...
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] net: bnx2x: fix error value sign
2010-11-14 20:29 ` Eric Dumazet
@ 2010-11-14 20:32 ` Eric Dumazet
2010-11-17 20:23 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: Eric Dumazet @ 2010-11-14 20:32 UTC (permalink / raw)
To: Vasiliy Kulikov; +Cc: kernel-janitors, Eilon Greenstein, netdev, linux-kernel
Le dimanche 14 novembre 2010 à 21:29 +0100, Eric Dumazet a écrit :
> I remember sending same patch in the past... it was lost somehow...
Ah, it was another issue, patch was not lost ;)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: bnx2x: fix error value sign
2010-11-14 20:32 ` Eric Dumazet
@ 2010-11-17 20:23 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2010-11-17 20:23 UTC (permalink / raw)
To: eric.dumazet; +Cc: segoon, kernel-janitors, eilong, netdev, linux-kernel
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sun, 14 Nov 2010 21:32:08 +0100
> Le dimanche 14 novembre 2010 à 21:29 +0100, Eric Dumazet a écrit :
>
>> I remember sending same patch in the past... it was lost somehow...
>
> Ah, it was another issue, patch was not lost ;)
:-) Applied, thanks everyone.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-11-17 20:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-14 20:08 [PATCH] net: bnx2x: fix error value sign Vasiliy Kulikov
2010-11-14 20:26 ` Eilon Greenstein
2010-11-14 20:29 ` Eric Dumazet
2010-11-14 20:32 ` Eric Dumazet
2010-11-17 20:23 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).