From: Ben Hutchings <bhutchings@solarflare.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
davem@davemloft.net, shemminger@linux-foundation.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] tcp: restrict net.ipv4.tcp_adv_min_scale (#20312)
Date: Mon, 15 Nov 2010 14:18:42 +0000 [thread overview]
Message-ID: <1289830722.2586.5.camel@bwh-desktop> (raw)
In-Reply-To: <20101114201458.GA28181@core2.telecom.by>
On Sun, 2010-11-14 at 22:14 +0200, Alexey Dobriyan wrote:
> On Sun, Nov 14, 2010 at 08:49:43PM +0100, Eric Dumazet wrote:
> > > +static int _minus_31 = -31;
> > > +static int _31 = 31;
> >
> > Please use normal symbols, not starting by underscore.
>
> static int thirty_one = 31? :-)
How about, oh, I don't know, adv_win_scale_{min,max}?
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2010-11-15 14:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-14 15:18 [PATCH] tcp: restrict net.ipv4.tcp_adv_min_scale (#20312) Alexey Dobriyan
2010-11-14 19:49 ` Eric Dumazet
2010-11-14 20:14 ` Alexey Dobriyan
2010-11-15 14:18 ` Ben Hutchings [this message]
2010-11-22 22:54 ` [PATCH v2] tcp: restrict net.ipv4.tcp_adv_win_scale (#20312) Alexey Dobriyan
2010-11-28 18:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289830722.2586.5.camel@bwh-desktop \
--to=bhutchings@solarflare.com \
--cc=adobriyan@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).