From: Andy Whitcroft <apw@canonical.com>
To: "David S. Miller\"" <davem@davemloft.net>,
Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Whitcroft <apw@canonical.com>,
Tim Gardner <tim.gardner@canonical.com>
Subject: [PATCH 0/1] rtnetlink/netdevice include triggers userspace compiler errors
Date: Mon, 15 Nov 2010 16:01:58 +0000 [thread overview]
Message-ID: <1289836919-19153-1-git-send-email-apw@canonical.com> (raw)
We have seen a number of reports of userspace applications (including
eglibc) which fail to compile when trying to use linux/rtnetlink.h.
It appears that a new helper function has necessitated the inclusion of
linux/netdevice.h which in turn causes a collision with userspace headers
from libc, with net/if.h.
It appears that this header is not required for the userspace exported
components of rtnetlink.h. Following this email is a patch to pull this
include down in the the kernel specific section of this header. It seems
to both fix this issue for userspace and still compiles correctly for
kernel use.
Against v2.6.37-rc1.
-apw
Andy Whitcroft (1):
net: rtnetlink.h -- only include linux/netdevice.h when used by the
kernel
include/linux/rtnetlink.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
next reply other threads:[~2010-11-15 16:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-15 16:01 Andy Whitcroft [this message]
2010-11-15 16:01 ` [PATCH 1/1] net: rtnetlink.h -- only include linux/netdevice.h when used by the kernel Andy Whitcroft
2010-11-15 19:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289836919-19153-1-git-send-email-apw@canonical.com \
--to=apw@canonical.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tim.gardner@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).