Re: [RFC PATCH v1 1/2] net: implement mechanism for HW based QOS

Thomas Graf
2010-11-17T09:18:29Z

On Tue, Nov 16, 2010 at 09:15:45PM -0800, John Fastabend wrote:
> This patch provides a mechanism for lower layer devices to
> steer traffic using skb->priority to tx queues. This allows
> for hardware based QOS schemes to use the default qdisc without
> incurring the penalties related to global state and the qdisc
> lock. While reliably receiving skbs on the correct tx ring
> to avoid head of line blocking resulting from shuffling in
> the LLD. Finally, all the goodness from txq caching and xps/rps
> can still be leveraged.

Nice.

> If this approach seems reasonable I'll go ahead and finish
> this up. The priority to tc mapping should probably be exposed
> to userspace either through sysfs or rtnetlink. Any thoughts?

Please use netlink for this and add a new IFLA_ attribute. I
suggest you put nested attributes into it so you can extend it
later on and/or obsolete attributes:

[IFLA_TC] = {
[IFLA_TC_MAX_TCS]
[IFLA_TC_NUM_TCS]
[IFLA_TC_TXQCOUNT]
[IFLA_TC_TXQOFFSET]
[IFLA_TC_MAP]
}

Or whatever is reasonable to export to userspace.