From: Ben Hutchings <bhutchings@solarflare.com>
To: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: netdev@vger.kernel.org
Subject: Re: [RFC PATCH 0/3] e1000/e1000e/igb MDI-X control implementation
Date: Thu, 18 Nov 2010 00:14:13 +0000 [thread overview]
Message-ID: <1290039253.30433.85.camel@localhost> (raw)
In-Reply-To: <20101117232645.3513.20655.stgit@jbrandeb-ich9b.jf.intel.com>
On Wed, 2010-11-17 at 15:29 -0800, Jesse Brandeburg wrote:
> this patch series is RFC for implemenation, I've briefly tested
> it to make sure I still get link after setting MDI-X and I see
> the status change in ethtool.
>
> The basic idea is to fill out the MDI-X read functionality with
> some write functionality.
>
> the e1000e patch is actually what drove this change as some users
> have found wonky switches that must have MDI/MDI-X forced.
[...]
I object to all these for the reasons explained in my comments on the
changes to the ethtool utility.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
prev parent reply other threads:[~2010-11-18 0:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 23:29 [RFC PATCH 0/3] e1000/e1000e/igb MDI-X control implementation Jesse Brandeburg
2010-11-17 23:29 ` [RFC PATCH 1/3] e1000e: implement MDI-X control Jesse Brandeburg
2010-11-17 23:29 ` [RFC PATCH 2/3] igb: update to allow reading/setting mdix Jesse Brandeburg
2010-11-17 23:29 ` [RFC PATCH 3/3] e1000: configure and read mdix settings Jesse Brandeburg
2010-11-18 0:14 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290039253.30433.85.camel@localhost \
--to=bhutchings@solarflare.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).