netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sonny Rao <sonnyrao@linux.vnet.ibm.com>
To: netdev@vger.kernel.org
Cc: Sonny Rao <sonnyrao@linux.vnet.ibm.com>,
	Milton Miller <miltonm@bga.com>,
	Ron Mercer <ron.mercer@qlogic.com>,
	linux-driver@qlogic.com, linux-kernel@vger.kernel.org
Subject: [PATCH] qlge: Fix incorrect usage of module parameters and netdev msg level
Date: Thu, 18 Nov 2010 04:25:03 -0600	[thread overview]
Message-ID: <1290075903-3038-1-git-send-email-sonnyrao@linux.vnet.ibm.com> (raw)

Driver appears to be mistaking the permission field with default value
in the case of debug and qlge_irq_type.

Driver is also passing debug as a bitmask into netif_msg_init()
which really wants a number of bits, so fix that.

Signed-off-by: Milton Miller <miltonm@bga.com>
Signed-off-by: Sonny Rao <sonnyrao@linux.vnet.ibm.com>
---
 drivers/net/qlge/qlge_main.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/qlge/qlge_main.c b/drivers/net/qlge/qlge_main.c
index d9a7626..66878bb 100644
--- a/drivers/net/qlge/qlge_main.c
+++ b/drivers/net/qlge/qlge_main.c
@@ -62,15 +62,15 @@ static const u32 default_msg =
 /* NETIF_MSG_PKTDATA | */
     NETIF_MSG_HW | NETIF_MSG_WOL | 0;

-static int debug = 0x00007fff;	/* defaults above */
-module_param(debug, int, 0);
+static int debug = 15;	/* defaults above */
+module_param(debug, int, 0664);
 MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)");

 #define MSIX_IRQ 0
 #define MSI_IRQ 1
 #define LEG_IRQ 2
 static int qlge_irq_type = MSIX_IRQ;
-module_param(qlge_irq_type, int, MSIX_IRQ);
+module_param(qlge_irq_type, int, 0664);
 MODULE_PARM_DESC(qlge_irq_type, "0 = MSI-X, 1 = MSI, 2 = Legacy.");

 static int qlge_mpi_coredump;
-- 
1.5.6.5


             reply	other threads:[~2010-11-18 19:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-18 10:25 Sonny Rao [this message]
2010-11-18 17:22 ` [PATCH] qlge: Fix incorrect usage of module parameters and netdev msg level Ron Mercer
2010-11-18 19:30 ` David Miller
2010-11-22 16:29 ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2010-11-18 21:50 Sonny Rao
2010-11-18 22:17 ` Ron Mercer
2010-11-18 23:12   ` Sonny Rao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1290075903-3038-1-git-send-email-sonnyrao@linux.vnet.ibm.com \
    --to=sonnyrao@linux.vnet.ibm.com \
    --cc=linux-driver@qlogic.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miltonm@bga.com \
    --cc=netdev@vger.kernel.org \
    --cc=ron.mercer@qlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).