From: Joe Perches <joe@perches.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Nicolas Kaiser <nikai@nikai.net>,
Samuel Ortiz <samuel@sortiz.org>,
Kuninori Morimoto <morimoto.kuninori@renesas.com>,
irda-users@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] SuperH IrDA: correct Baud rate error correction
Date: Thu, 18 Nov 2010 17:05:04 -0800 [thread overview]
Message-ID: <1290128704.1817.56.camel@Joe-Laptop> (raw)
In-Reply-To: <20101118164150.22aa7e16@nehalam>
On Thu, 2010-11-18 at 16:41 -0800, Stephen Hemminger wrote:
> On Fri, 19 Nov 2010 01:24:02 +0100
> Nicolas Kaiser <nikai@nikai.net> wrote:
> > u32 rate_err_array[] = {
> > - 0000, 0625, 1250, 1875,
> > + 0, 625, 1250, 1875,
> > 2500, 3125, 3750, 4375,
> > 5000, 5625, 6250, 6875,
> > 7500, 8125, 8750, 9375,
> While you are at it make that table const.
Good find Nicolas.
static const might be better still.
prev parent reply other threads:[~2010-11-19 1:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 0:24 [PATCH] SuperH IrDA: correct Baud rate error correction Nicolas Kaiser
2010-11-19 0:41 ` Stephen Hemminger
2010-11-19 1:05 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290128704.1817.56.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=irda-users@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=morimoto.kuninori@renesas.com \
--cc=netdev@vger.kernel.org \
--cc=nikai@nikai.net \
--cc=samuel@sortiz.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).